Add more AsSpan overloads to StringSegment

[BrennanConroy]

Background and Motivation

Many classes provide AsSpan methods and most provide at least the 3 basic methods, AsSpan(), AsSpan(int start), AsSpan(int start, int length).

The StringSegment class only provides AsSpan(), but it should provide the other two for consistency and ease of use.

Proposed API

namespace Microsoft.Extensions.Primitives
{
    public readonly struct StringSegment : IEquatable<StringSegment>, IEquatable<string>
    {
        public ReadOnlySpan<char> AsSpan();
+       public ReadOnlySpan<char> AsSpan(int start);
+       public ReadOnlySpan<char> AsSpan(int start, int length);
    }
}

Usage Examples

// input.AsSpan().Slice(startIndex, typeLength);
input.AsSpan(startIndex, typeLength);

Alternative Designs

No, other classes that provide AsSpan have similar overloads

Risks

None

[ghost]

Tagging subscribers to this area: @GrabYourPitchforks, @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and Motivation

Many classes provide AsSpan methods and most provide at least the 3 basic methods, AsSpan(), AsSpan(int start), AsSpan(int start, int length).

The StringSegment class only provides AsSpan(), but it should provide the other two for consistency and ease of use.

Proposed API

namespace Microsoft.Extensions.Primitives
{
    public readonly struct StringSegment : IEquatable<StringSegment>, IEquatable<string>
    {
        public ReadOnlySpan<char> AsSpan();
+       public ReadOnlySpan<char> AsSpan(int start);
+       public ReadOnlySpan<char> AsSpan(int start, int length);
    }
}

Usage Examples

// input.AsSpan().Slice(startIndex, typeLength);
input.AsSpan(startIndex, typeLength);

Alternative Designs

No, other classes that provide AsSpan have similar overloads

Risks

None

Author:	BrennanConroy
Assignees:	-
Labels:	api-suggestion, area-System.Memory, untriaged
Milestone:	-

[ghost]

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and Motivation

Many classes provide AsSpan methods and most provide at least the 3 basic methods, AsSpan(), AsSpan(int start), AsSpan(int start, int length).

The StringSegment class only provides AsSpan(), but it should provide the other two for consistency and ease of use.

Proposed API

namespace Microsoft.Extensions.Primitives
{
    public readonly struct StringSegment : IEquatable<StringSegment>, IEquatable<string>
    {
        public ReadOnlySpan<char> AsSpan();
+       public ReadOnlySpan<char> AsSpan(int start);
+       public ReadOnlySpan<char> AsSpan(int start, int length);
    }
}

Usage Examples

// input.AsSpan().Slice(startIndex, typeLength);
input.AsSpan(startIndex, typeLength);

Alternative Designs

No, other classes that provide AsSpan have similar overloads

Risks

None

Author:	BrennanConroy
Assignees:	-
Labels:	api-ready-for-review, area-Extensions-Primitives
Milestone:	-

[bartonjs]

Video

Looks good as proposed.

namespace Microsoft.Extensions.Primitives
{
    partial struct StringSegment : IEquatable<StringSegment>, IEquatable<string>
    {
       public ReadOnlySpan<char> AsSpan(int start);
       public ReadOnlySpan<char> AsSpan(int start, int length);
    }
}

[gfoidl]

I'd like to add these overloads.