Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP/3] Disabled test classes #53093

Closed
ManickaP opened this issue May 21, 2021 · 3 comments · Fixed by #54727 or #56831
Closed

[HTTP/3] Disabled test classes #53093

ManickaP opened this issue May 21, 2021 · 3 comments · Fixed by #54727 or #56831
Assignees
@ManickaP
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue
Milestone
6.0.0

Comments

@ManickaP
Copy link
Member

ManickaP commented May 21, 2021 •
edited
Loading

In HTTP functional tests, there is 3 places where the whole test classes are suppressed with #if false:

This issue is to serve as a reminder to investigate and either fix or delete the tests. This issue can be split into separate ones for individual problems.
@ManickaP ManickaP added area-System.Net.Http disabled-test The test is disabled in source code against the issue labels May 21, 2021
@ManickaP ManickaP added this to the Future milestone May 21, 2021
@ghost
Copy link

ghost commented May 21, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

In HTTP functional tests, there is 3 places where the whole test classes are suppressed with #if false:

  • Cookies: SocketsHttpHandlerTest_Cookies_Http3_MsQuic and SocketsHttpHandlerTest_Cookies_Http3_Mock
  • Cancellation: SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic and SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock
  • AltSvc: SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic and SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock

This issue is to serve as a reminder to investigate and either fix or delete the tests. This issue can be split into separate ones for individual problems.

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http, disabled-test
Milestone: Future

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 21, 2021
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label May 21, 2021
@ManickaP ManickaP mentioned this issue May 21, 2021
Merged
@karelz karelz modified the milestones: Future, 6.0.0 May 25, 2021
@ManickaP ManickaP self-assigned this Jun 6, 2021
@ManickaP ManickaP mentioned this issue Jun 6, 2021
Merged
@ManickaP ManickaP added disabled-test The test is disabled in source code against the issue and removed disabled-test The test is disabled in source code against the issue labels Jun 15, 2021
@ManickaP ManickaP removed their assignment Jun 15, 2021
@CarnaViire CarnaViire self-assigned this Jun 21, 2021
@karelz karelz assigned geoffkizer and unassigned CarnaViire Jun 24, 2021
This was referenced Jun 24, 2021
Closed
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 25, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 26, 2021
@geoffkizer geoffkizer reopened this Jun 28, 2021
@geoffkizer
Copy link
Contributor

Reopened since I'm disabling the cookie tests again.

@karelz
Copy link
Member

karelz commented Jul 13, 2021

Triage: Cookie tests blocked on #55025

@ManickaP ManickaP mentioned this issue Aug 4, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2021
@ManickaP ManickaP self-assigned this Aug 4, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2021
@ManickaP ManickaP changed the title [HTTP/3] Disabled test classes [HTTP/3] Disabled cookie tests Aug 4, 2021
@ManickaP ManickaP changed the title [HTTP/3] Disabled cookie tests [HTTP/3] Disabled test classes Aug 4, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ManickaP ManickaP

Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
6.0.0
4 participants
@CarnaViire @karelz @ManickaP @geoffkizer