Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CrossGen build to better support arbitrary RIDs #54513

Open
MichaelSimons opened this issue Jun 21, 2021 · 1 comment
Open

Refactor CrossGen build to better support arbitrary RIDs #54513

MichaelSimons opened this issue Jun 21, 2021 · 1 comment

Comments

@MichaelSimons
Copy link
Member

This issue stems from review feedback from this PR.

The general issue is that the CrossGen project has a hard coded RID list it supports. This hard coded list doesn't work for source-build, which needs to build arbitrary non-portable RIDs like centos.8-x64 and banana.42-x64 with no unexpected feature gaps vs. portable RIDs. Currently, source-build conditionally disables the hard coded RID list but this could be improved. It could have a list of "good" portable RIDs, and check if the current RID is a descendant of any of the "good" RIDs in the RID graph. Then, there would be no need for source-build-specific behavior, because banana.42-x64 derives from linux-x64.

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer added this to the Future milestone Jun 21, 2021
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants