Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address System.Reflection.Context's nullable warnings targeting .NETCoreApp #54596

Closed
ViktorHofer opened this issue Jun 23, 2021 · 0 comments · Fixed by #54938
Closed

Address System.Reflection.Context's nullable warnings targeting .NETCoreApp #54596

ViktorHofer opened this issue Jun 23, 2021 · 0 comments · Fixed by #54938
Assignees
@stephentoub
Labels
area-System.Reflection help wanted [up-for-grabs] Good issue for external contributors untriaged New issue has not been triaged by the area owner
Milestone
Future

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 23, 2021 •
edited
Loading

When adding a NetCoreAppCurrent TFM to System.Reflection.Context, more than 250 nullable warnings pop up that would need to be addressed.

Meanwhile the <Nullable> setting for NetCoreAppCurrent is set to annotations only to avoid the warnings in the build.

Related: #54012
@ViktorHofer ViktorHofer added area-System.Reflection help wanted [up-for-grabs] Good issue for external contributors labels Jun 23, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 23, 2021
@ViktorHofer ViktorHofer added this to the Future milestone Jun 23, 2021
@stephentoub stephentoub self-assigned this Jun 30, 2021
@stephentoub stephentoub mentioned this issue Jun 30, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 30, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.Reflection help wanted [up-for-grabs] Good issue for external contributors untriaged New issue has not been triaged by the area owner
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Annotate System.Reflection.Context for nullability stephentoub/runtime
2 participants
@stephentoub @ViktorHofer