Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsQuic configuration handle is created but not used #55158

Closed
geoffkizer opened this issue Jul 5, 2021 · 4 comments · Fixed by #55795
Closed

MsQuic configuration handle is created but not used #55158

geoffkizer opened this issue Jul 5, 2021 · 4 comments · Fixed by #55795
Assignees
@wfurt
Labels
area-System.Net.Quic
Milestone
6.0.0

Comments

@geoffkizer
Copy link
Contributor

See https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs#L175
@geoffkizer geoffkizer added this to the 6.0.0 milestone Jul 5, 2021
@ghost
Copy link

ghost commented Jul 5, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

See https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs#L175

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Quic
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 5, 2021
@geoffkizer
Copy link
Contributor Author

Note also, we create another equivalent config handle here: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs#L162

This one is stored into a field, then used later in ConnectAsync.

This all seems less than ideal. I wonder if we should just pass QuicClientConnectionOptions to ConnectAsync, or something like that.

@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2021
@ManickaP
Copy link
Member

Relevant issue: #42642

@ManickaP ManickaP modified the milestones: 6.0.0, 7.0.0 Jul 15, 2021
@karelz
Copy link
Member

karelz commented Jul 15, 2021 •
edited
Loading

Triage: Not needed for 6.0, but super simple (remove 1 line).

@ManickaP ManickaP mentioned this issue Jul 16, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 16, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 20, 2021
@karelz karelz modified the milestones: 7.0.0, 6.0.0 Jul 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wfurt wfurt

Labels
area-System.Net.Quic
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

remove unnecessary call wfurt/runtime
4 participants
@karelz @ManickaP @geoffkizer @wfurt