[Perf] [WASM] Regression in dotnet.wasm #55608
Comments
DrewScoggins
added
tenet-performance
dotnet-issue-labeler
bot
added
area-Diagnostics-coreclr
untriaged
|
@DrewScoggins - there are 146 commits in the Diff at the top of this issue. Any way we can narrow them down? |
|
The 5% regression in System.Text.Json in the PizzaApp, it appears to maybe be caused by dotnet/linker#2125. Looking at a diff of System.Text.Json before and after I'm seeing:
Note, the PizzaApp does use System.Linq.Expressions. Looking at ILSpy, I see it being used by the AddressEditor:
cc @sbomer @vitek-karas - FYI |
|
The even worse regression here is:
@SamMonoRT @lewing - did something break here that we lost all the re-linking work for the "Minimum" app (i.e. Invariant Globalization mode)? |
|
@eerhardt right now all the components are being linked in unconditionally (hot-reload and the debugger) fix coming soon. |
ghost
added
the
in-pr
|
Tagging subscribers to this area: @thaystg Issue DetailsRun Information
Regressions in SOD - Minimum Blazor Template - Publish
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Minimum Blazor Template - Publish*'PayloadsHistogramSOD - Minimum Blazor Template - PublishDocsProfiling workflow for dotnet/runtime repository
Regressions in SOD - Pizza App - Publish
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Pizza App - Publish*'PayloadsHistogramSOD - Pizza App - PublishDocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in SOD - New Blazor Template - Publish
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - New Blazor Template - Publish*'PayloadsHistogramSOD - New Blazor Template - PublishDocsProfiling workflow for dotnet/runtime repository
|
hoyosjs
added
area-VM-meta-mono
and removed
area-Debugger-mono
area-Diagnostics-coreclr
labels
|
Tagging subscribers to this area: Issue DetailsRun Information
Regressions in SOD - Minimum Blazor Template - Publish
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Minimum Blazor Template - Publish*'PayloadsHistogramSOD - Minimum Blazor Template - PublishDocsProfiling workflow for dotnet/runtime repository
Regressions in SOD - Pizza App - Publish
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Pizza App - Publish*'PayloadsHistogramSOD - Pizza App - PublishDocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in SOD - New Blazor Template - Publish
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - New Blazor Template - Publish*'PayloadsHistogramSOD - New Blazor Template - PublishDocsProfiling workflow for dotnet/runtime repository
|
ghost
removed
the
in-pr
@eerhardt - Larry's PR change closed this issue which covered both STJ and dotnet.wasm regressions. Are we tracking this STJ regression outside of this issue. |
|
The components are being correctly linked out and the runtime is being relinked but it looks like something is retaining icu in invariantmode now. |
I believe that STJ regression is expected, given that the PizzaApp is using |
|
Found the runtime issue, fix incoming. You will like the result. |
|
@radical - didn't see any decrease in size for dotnet.wasm in the runs with the change. Please take a look. @DrewScoggins is your main contact for dashboard questions. This is the size regression in the minimal wasm app. |
|
Are these projects built with Debug config? Larry's PR (#55939) affects Release builds. In Release config, we use native relinking is enabled. This is for a template blazorwasm project with Debug: |
|
@radical @DrewScoggins - Looking at https://github.com/dotnet/performance/blob/da8322773787ba87b2305899095fc587d5668929/src/scenarios/blazorminapp/pre.py seems like InvariantGlobalization is set to true correctly for the min app. |
Yeah, that makes sense. |
|
Drew's PR to udpate workload name should hopefully fix the dotnet.wasm.br regression |
|
@radical @lewing - From @DrewScoggins :: We are at 1.11MB with the updated workload name. We don't have the breakdown of file size as of now. I assume the PowerBI won't be updated till the actual fix is merged. [1:37 AM] Drew Scoggins [1:37 AM] Drew Scoggins [1:38 AM] Drew Scoggins [1:38 AM] Drew Scoggins [1:39 AM] Drew Scoggins |
|
We can close this issue, as the core regression is addressed. |
ghost
locked as resolved and limited conversation to collaborators
Run Information
Regressions in SOD - Minimum Blazor Template - Publish
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
SOD - Minimum Blazor Template - Publish
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Regressions in SOD - Pizza App - Publish
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
SOD - Pizza App - Publish
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in SOD - New Blazor Template - Publish
Historical Data in Reporting System
Repro
Payloads
Baseline
Compare
Histogram
SOD - New Blazor Template - Publish
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: