Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Regressions in System.ComponentModel.TypeConverter.dll, System.ComponentModel.Primitives.dll, and System.Private.Runtime.InteropServices.JavaScript.dll #56563

Closed
performanceautofiler bot opened this issue Jul 29, 2021 · 6 comments
Closed

[Perf] Regressions in System.ComponentModel.TypeConverter.dll, System.ComponentModel.Primitives.dll, and System.Private.Runtime.InteropServices.JavaScript.dll #56563

performanceautofiler bot opened this issue Jul 29, 2021 · 6 comments
Labels
arch-wasm WebAssembly architecture area-System.ComponentModel tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark untriaged New issue has not been triaged by the area owner

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 2053d653bfd7fc0a5d073a5d31e01600d2d5fa3f
Compare 3c253d18e88da47b4c26643b4228414c6259ce23
Diff Diff

Regressions in SOD - New Blazor Template - Publish

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Web.dll.br 8.12 KB 8.21 KB 1.01 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll 21.00 KB 21.50 KB 1.02 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz 9.94 KB 10.39 KB 1.05 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz 72.63 KB 74.56 KB 1.03 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br 8.79 KB 9.22 KB 1.05 0.00 True

graph
graph
graph
graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - New Blazor Template - Publish*'

Payloads

Baseline
Compare

Histogram

SOD - New Blazor Template - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS ubuntu 18.04
Baseline 2053d653bfd7fc0a5d073a5d31e01600d2d5fa3f
Compare 3c253d18e88da47b4c26643b4228414c6259ce23
Diff Diff

Regressions in SOD - Pizza App - Publish

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Authorization.dll.br 6.45 KB 6.34 KB 0.98 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Forms.dll.br 7.18 KB 7.11 KB 0.99 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Runtime.CompilerServices.Unsafe.dll.br 1.12 KB 1.16 KB 1.03 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll 72.00 KB 88.00 KB 1.22 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll.br 7.28 KB 7.56 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll.gz 2.84 KB 3.25 KB 1.15 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz 10.49 KB 10.95 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll 7.00 KB 8.00 KB 1.14 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll.gz 28.87 KB 35.85 KB 1.24 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll.gz 8.30 KB 8.65 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz 72.63 KB 74.56 KB 1.03 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll 22.00 KB 23.00 KB 1.05 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Web.dll.br 10.17 KB 10.28 KB 1.01 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll.br 2.50 KB 2.89 KB 1.15 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll.br 24.55 KB 30.93 KB 1.26 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Annotations.dll.br 7.92 KB 8.01 KB 1.01 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br 9.21 KB 9.65 KB 1.05 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll 19.00 KB 20.00 KB 1.05 0.00 True

graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Pizza App - Publish*'

Payloads

Baseline
Compare

Histogram

SOD - Pizza App - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@Tohron Tohron transferred this issue from dotnet/perf-autofiling-issues Jul 29, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 29, 2021
@Tohron Tohron changed the title [Perf] Changes at 7/29/2021 8:46:28 AM [Perf] Regressions in System.ComponentModel.TypeConverter.dll, System.ComponentModel.Primitives.dll, and System.Private.Runtime.InteropServices.JavaScript.dll Jul 29, 2021
@Tohron
Copy link
Contributor

Tohron commented Jul 29, 2021

I noted regressions in System.ComponentModel.TypeConverter.dll, System.ComponentModel.Primitives.dll, and System.Private.Runtime.InteropServices.JavaScript.dll under SOD - Pizza App - Publish. Seems like they might bear investigating.

@Tohron Tohron added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Jul 29, 2021
@ghost
Copy link

ghost commented Jul 30, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 2053d653bfd7fc0a5d073a5d31e01600d2d5fa3f
Compare 3c253d18e88da47b4c26643b4228414c6259ce23
Diff Diff

Regressions in SOD - New Blazor Template - Publish

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Web.dll.br 8.12 KB 8.21 KB 1.01 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll 21.00 KB 21.50 KB 1.02 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz 9.94 KB 10.39 KB 1.05 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz 72.63 KB 74.56 KB 1.03 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br 8.79 KB 9.22 KB 1.05 0.00 True

graph
graph
graph
graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - New Blazor Template - Publish*'

Payloads

Baseline
Compare

Histogram

SOD - New Blazor Template - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS ubuntu 18.04
Baseline 2053d653bfd7fc0a5d073a5d31e01600d2d5fa3f
Compare 3c253d18e88da47b4c26643b4228414c6259ce23
Diff Diff

Regressions in SOD - Pizza App - Publish

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Authorization.dll.br 6.45 KB 6.34 KB 0.98 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Forms.dll.br 7.18 KB 7.11 KB 0.99 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Runtime.CompilerServices.Unsafe.dll.br 1.12 KB 1.16 KB 1.03 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll 72.00 KB 88.00 KB 1.22 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll.br 7.28 KB 7.56 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll.gz 2.84 KB 3.25 KB 1.15 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz 10.49 KB 10.95 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll 7.00 KB 8.00 KB 1.14 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll.gz 28.87 KB 35.85 KB 1.24 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll.gz 8.30 KB 8.65 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz 72.63 KB 74.56 KB 1.03 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll 22.00 KB 23.00 KB 1.05 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Web.dll.br 10.17 KB 10.28 KB 1.01 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll.br 2.50 KB 2.89 KB 1.15 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll.br 24.55 KB 30.93 KB 1.26 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Annotations.dll.br 7.92 KB 8.01 KB 1.01 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br 9.21 KB 9.65 KB 1.05 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll 19.00 KB 20.00 KB 1.05 0.00 True

graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Pizza App - Publish*'

Payloads

Baseline
Compare

Histogram

SOD - Pizza App - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.ComponentModel, tenet-performance, tenet-performance-benchmarks, untriaged
Milestone: -

@safern safern added the arch-wasm WebAssembly architecture label Jul 30, 2021
@ghost
Copy link

ghost commented Jul 30, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 2053d653bfd7fc0a5d073a5d31e01600d2d5fa3f
Compare 3c253d18e88da47b4c26643b4228414c6259ce23
Diff Diff

Regressions in SOD - New Blazor Template - Publish

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Web.dll.br 8.12 KB 8.21 KB 1.01 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll 21.00 KB 21.50 KB 1.02 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz 9.94 KB 10.39 KB 1.05 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz 72.63 KB 74.56 KB 1.03 0.00 True
SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br 8.79 KB 9.22 KB 1.05 0.00 True

graph
graph
graph
graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - New Blazor Template - Publish*'

Payloads

Baseline
Compare

Histogram

SOD - New Blazor Template - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS ubuntu 18.04
Baseline 2053d653bfd7fc0a5d073a5d31e01600d2d5fa3f
Compare 3c253d18e88da47b4c26643b4228414c6259ce23
Diff Diff

Regressions in SOD - Pizza App - Publish

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Authorization.dll.br 6.45 KB 6.34 KB 0.98 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Forms.dll.br 7.18 KB 7.11 KB 0.99 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Runtime.CompilerServices.Unsafe.dll.br 1.12 KB 1.16 KB 1.03 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll 72.00 KB 88.00 KB 1.22 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll.br 7.28 KB 7.56 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll.gz 2.84 KB 3.25 KB 1.15 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz 10.49 KB 10.95 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll 7.00 KB 8.00 KB 1.14 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll.gz 28.87 KB 35.85 KB 1.24 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll.gz 8.30 KB 8.65 KB 1.04 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz 72.63 KB 74.56 KB 1.03 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll 22.00 KB 23.00 KB 1.05 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.Web.dll.br 10.17 KB 10.28 KB 1.01 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Primitives.dll.br 2.50 KB 2.89 KB 1.15 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.TypeConverter.dll.br 24.55 KB 30.93 KB 1.26 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.ComponentModel.Annotations.dll.br 7.92 KB 8.01 KB 1.01 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br 9.21 KB 9.65 KB 1.05 0.00 True
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Linq.dll 19.00 KB 20.00 KB 1.05 0.00 True

graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Pizza App - Publish*'

Payloads

Baseline
Compare

Histogram

SOD - Pizza App - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

arch-wasm, area-System.ComponentModel, tenet-performance, tenet-performance-benchmarks, untriaged
Milestone: -

@lewing
Copy link
Member

lewing commented Jul 31, 2021

I noted regressions in System.ComponentModel.TypeConverter.dll, System.ComponentModel.Primitives.dll, and System.Private.Runtime.InteropServices.JavaScript.dll under SOD - Pizza App - Publish. Seems like they might bear investigating.

Agreed, I'm not sure where those are coming from. The small increase in InteropServices.Javascript is expected.

@eerhardt
Copy link
Member

eerhardt commented Aug 5, 2021

This looks like a duplicate of #56631.

I believe both issues were caused by fixing #51772, which brought in more code in System.ComponentModel, because it is required to fix the bug.

This size increase is expected.

@eerhardt eerhardt closed this as completed Aug 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.ComponentModel tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lewing @eerhardt @jeffschwMSFT @safern @Tohron