Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossgen2 JIT stress testing #58388

Open
BruceForstall opened this issue Aug 30, 2021 · 1 comment
Open

crossgen2 JIT stress testing #58388

BruceForstall opened this issue Aug 30, 2021 · 1 comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes
Milestone

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Aug 30, 2021

Crossgen2 testing, such as the crossgen2 / r2r AzDO test jobs, work as follows:

  1. crossgen the framework
  2. crossgen every test
  3. Run the tests

Issues:

  1. For the modes that set the JIT stress variables, before running the tests, we set COMPlus variables, in the wrapper script. However, crossgen2 ignores environment variables so the compiled test doesn't get compiled with the stress mode. At best, if crossgen2 is compiled/run with a Checked JIT, crossgen2 itself might be compiled/run with the JIT stress mode.

  2. The JIT stress modes are not applied to the crossgen2 compilation of the framework assemblies

To do: decide exactly what should be affected by the JIT stress variables (presumably, the compilation of the framework and the compilation of each test; optionally, the compilation/run of crossgen2 itself), and adjust the AzDO pipelines to match.

@dotnet/jit-contrib

category:testing
theme:testing
skill-level:beginner
cost:small
impact:medium

@BruceForstall BruceForstall added JitStress CLR JIT issues involving JIT internal stress modes area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Aug 30, 2021
@BruceForstall BruceForstall added this to the 7.0.0 milestone Aug 30, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 30, 2021
@ghost
Copy link

ghost commented Aug 30, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Crossgen2 testing, such as the crossgen2 / r2r AzDO test jobs, work as follows:

  1. crossgen the framework
  2. crossgen every test
  3. Run the tests

Issues:

  1. For the modes that set the JIT stress variables, before running the tests, we set COMPlus variables, in the wrapper script. However, crossgen2 ignores environment variables so the compiled test doesn't get compiled with the stress mode. At best, if crossgen2 is compiled/run with a Checked JIT, crossgen2 itself might be compiled/run with the JIT stress mode.

  2. The JIT stress modes are not applied to the crossgen2 compilation of the framework assemblies

To do: decided exactly what should be affected by the JIT stress variables (presumably, the compilation of the framework and the compilation of each test; optionally, the compilation/run of crossgen2 itself), and adjust the AzDO pipelines to match.

@dotnet/jit-contrib

Author: BruceForstall
Assignees: -
Labels:

JitStress, area-CodeGen-coreclr

Milestone: 7.0.0

@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Aug 30, 2021
@BruceForstall BruceForstall modified the milestones: 7.0.0, 8.0.0 May 24, 2022
@BruceForstall BruceForstall removed their assignment May 24, 2022
@TIHan TIHan modified the milestones: 8.0.0, Future Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes
Projects
None yet
Development

No branches or pull requests

2 participants