Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generatelayoutonly without previously building the tests fails due to unrestored assets #60137

Closed
trylek opened this issue Oct 7, 2021 · 3 comments
Closed

generatelayoutonly without previously building the tests fails due to unrestored assets #60137

trylek opened this issue Oct 7, 2021 · 3 comments
Assignees
@trylek
Labels
area-Infrastructure-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs untriaged New issue has not been triaged by the area owner

Comments

@trylek
Copy link
Member

trylek commented Oct 7, 2021

My test build cleanup change

#58762

broke the scenario of populating CORE_ROOT without building the tests first. This is due to the fact that I overlooked the need for a dependency of the GenerateLayout target on the RestorePackages target. I have locally verified that I'm able to repro the failure and fix it with a change I'm currently testing in the lab:

#60136

Thanks

Tomas
@trylek trylek self-assigned this Oct 7, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Oct 7, 2021
@ghost
Copy link

ghost commented Oct 7, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

My test build cleanup change

#58762

broke the scenario of populating CORE_ROOT without building the tests first. This is due to the fact that I overlooked the need for a dependency of the GenerateLayout target on the RestorePackages target. I have locally verified that I'm able to repro the failure and fix it with a change I'm currently testing in the lab:

#60136

Thanks

Tomas

Author: trylek
Assignees: trylek
Labels:

area-Infrastructure-coreclr
Milestone: -

@BruceForstall BruceForstall added the blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs label Oct 7, 2021
@BruceForstall
Copy link
Member

@trylek fyi, this blocks our internal superpmi collection pipeline

cc @kunalspathak

@runfoapp runfoapp bot mentioned this issue Oct 7, 2021
Closed
@trylek trylek mentioned this issue Oct 7, 2021
Merged
@trylek
Copy link
Member Author

trylek commented Oct 7, 2021

The fix has just been merged in. Please let me know if you continue observing any difficulties in this area.

Thanks

Tomas

@trylek trylek closed this as completed Oct 7, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@trylek trylek

Labels
area-Infrastructure-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BruceForstall @trylek