Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPMI collections need to use release System.Private.Corelib #60947

Open
Tracked by #79018
AndyAyersMS opened this issue Oct 27, 2021 · 4 comments
Open
Tracked by #79018

SPMI collections need to use release System.Private.Corelib #60947

AndyAyersMS opened this issue Oct 27, 2021 · 4 comments
Assignees
@BruceForstall
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@AndyAyersMS
Copy link
Member

AndyAyersMS commented Oct 27, 2021 •
edited by BruceForstall
Loading

Checked builds of SPC contain Debug.Assert and other constructs that can give a misleading picture of codegen diffs.

See eg: #60943 (comment)

category:eng-sys
theme:super-pmi
skill-level:intermediate
cost:medium
impact:medium
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Oct 27, 2021
@ghost
Copy link

ghost commented Oct 27, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Checked builds of SPC contain Debug.Assert and other constructs that can give a misleading picture of codegen diffs.

See eg: #60943 (comment)

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

@BruceForstall
Copy link
Member

Currently, SPMI collections use Checked builds for everything. Should we use Release builds with an overlaid Checked JIT? I believe we need the Checked JIT, which will ask additional questions (mostly to get the full function names for Checked/Debug playback with JitDump).

Needing more than just Checked builds complicates things.

@AndyAyersMS
Copy link
Member Author

Should we use Release builds with an overlaid Checked JIT?

Yes, that's what I'd recommend. jit-diffs --pmi was intentionally set up this way.

@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Nov 1, 2021
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Nov 2, 2021
@BruceForstall BruceForstall modified the milestones: 7.0.0, 8.0.0 May 24, 2022
@BruceForstall BruceForstall mentioned this issue Nov 30, 2022
Closed
17 tasks
@AndyAyersMS AndyAyersMS mentioned this issue Apr 7, 2023
Merged
@BruceForstall BruceForstall modified the milestones: 8.0.0, Future Jun 16, 2023
@BruceForstall BruceForstall mentioned this issue Oct 6, 2023
Closed
10 tasks
@BruceForstall BruceForstall mentioned this issue Oct 15, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@jeffschwMSFT @AndyAyersMS @BruceForstall @JulieLeeMSFT