Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Handle exceptions while evaluating expressions #61665

Closed
thaystg opened this issue Nov 16, 2021 · 3 comments · Fixed by #64374
Closed

[wasm][debugger] Handle exceptions while evaluating expressions #61665

thaystg opened this issue Nov 16, 2021 · 3 comments · Fixed by #64374
Assignees
@thaystg
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone
7.0.0

Comments

@thaystg
Copy link
Member

thaystg commented Nov 16, 2021 •
edited
Loading

Look at @radical comments in this PR #61470 and fix it.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Debugger-mono untriaged New issue has not been triaged by the area owner labels Nov 16, 2021
@thaystg thaystg self-assigned this Nov 16, 2021
@ghost
Copy link

ghost commented Nov 16, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Look at @radical comments in this issue #61470 and fix it.

Author: thaystg
Assignees: -
Labels:

untriaged, area-Debugger-mono
Milestone: -

@thaystg thaystg mentioned this issue Nov 16, 2021
Merged
@radical radical added the arch-wasm WebAssembly architecture label Nov 17, 2021
@ghost
Copy link

ghost commented Nov 17, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Look at @radical comments in this PR #61470 and fix it.

Author: thaystg
Assignees: thaystg
Labels:

arch-wasm, untriaged, area-Debugger-mono
Milestone: -

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Nov 17, 2021
@lewing lewing added this to the 7.0.0 milestone Nov 17, 2021
@ilonatommy
Copy link
Member

ilonatommy commented Jan 25, 2022 •
edited
Loading

Bringing user's exceptions to the UI (e.g. by displaying them in Value field on frame evaluation in Watch) works fine and is tested in DebuggerTests.EvaluateOnCallFrameTests.EvaluatePropertyThatThrows().

For internal errors of evaluation, exception flow is not working properly:

  • in VS instead of our exception some VS one is thrown:
    Exception of type 'Microsoft.VisualStudio.Shared.VSCodeDebugProtocol.ProtocolException' was thrown. (Unable to evaluate)
  • in Browser user sees no exception.

@ilonatommy ilonatommy mentioned this issue Jan 27, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 27, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 17, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thaystg thaystg

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[wasm][debugger] Fix exceptions on eval ilonatommy/runtime
4 participants
@radical @lewing @thaystg @ilonatommy