Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move libraries shims under src/native #61864

Closed
jkotas opened this issue Nov 20, 2021 · 2 comments · Fixed by #61958
Closed

Move libraries shims under src/native #61864

jkotas opened this issue Nov 20, 2021 · 2 comments · Fixed by #61958

Comments

@jkotas
Copy link
Member

jkotas commented Nov 20, 2021

The current directory structure under src/libraries/native is confusing:

  • The sub-directory names do not match the OSes where the shims are actually building.
  • The shims are statically linked with the runtime in some configurations

We should consider moving all shims under src/native that seems to be the best place for unmanaged code shared between runtimes.

See #61852 (comment) for full context

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 20, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Nov 20, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

The current directory structure under src/libraries/native is confusing:

  • The sub-directory names do not match the OSes where the shims are actually building.
  • The shims are statically linked with the runtime in some configurations

We should consider moving all shims under src/native that seems to be the best place for unmanaged code shared between runtimes.

See #61852 (comment) for full context

Author: jkotas
Assignees: -
Labels:

area-Infrastructure-libraries, untriaged

Milestone: -

@safern safern removed the untriaged New issue has not been triaged by the area owner label Nov 20, 2021
@safern safern added this to the 7.0.0 milestone Nov 20, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 23, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants