Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Allow user to set -s ENVIRONMENT setting #62708

Closed
radekdoulik opened this issue Dec 13, 2021 · 1 comment · Fixed by #82954
Closed

[wasm] Allow user to set -s ENVIRONMENT setting #62708

radekdoulik opened this issue Dec 13, 2021 · 1 comment · Fixed by #82954
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
8.0.0

Comments

@radekdoulik
Copy link
Member

The environment setting can save small amount of size in dotnet.js.

It would be nice to autodetect which environment is needed during build or at least have a way to override it.
@radekdoulik radekdoulik added arch-wasm WebAssembly architecture area-Build-mono labels Dec 13, 2021
@radekdoulik radekdoulik added this to the 7.0.0 milestone Dec 13, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 13, 2021
@ghost
Copy link

ghost commented Dec 13, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The environment setting can save small amount of size in dotnet.js.

It would be nice to autodetect which environment is needed during build or at least have a way to override it.

Author: radekdoulik
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: 7.0.0

@radekdoulik radekdoulik mentioned this issue Dec 13, 2021
Merged
@radical radical removed the untriaged New issue has not been triaged by the area owner label Dec 13, 2021
@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 25, 2022
@pavelsavara pavelsavara self-assigned this Aug 22, 2022
@pavelsavara pavelsavara mentioned this issue Mar 3, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 3, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[browser] new EmccEnableAssertions and EmccEnvironment MSBuild props pavelsavara/runtime
4 participants
@radical @lewing @pavelsavara @radekdoulik