Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux][Arm64] Runtime test runs doesn't seem to respect build properties #65713

Closed
MaximLipnin opened this issue Feb 22, 2022 · 3 comments
Closed

[Linux][Arm64] Runtime test runs doesn't seem to respect build properties #65713

MaximLipnin opened this issue Feb 22, 2022 · 3 comments
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@MaximLipnin
Copy link
Contributor

The JIT/Methodical/NaN/r4nanconv_il_d and JIT/Methodical/NaN/r4nanconv_il_r should not run on Linux arm64 as they are disabled twice in the issues.targets file:

  • under Condition=" '$(RuntimeFlavor)' == 'mono' and '$(TargetArchitecture)' == 'arm64' and '$(TargetsWindows)' != 'true' "
  • under Condition="'$(RuntimeFlavor)' == 'mono' and '$(RuntimeVariant)' == 'monointerpreter' "

But based on #65681 (comment), they still run.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Feb 22, 2022
@ghost
Copy link

ghost commented Feb 22, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

The JIT/Methodical/NaN/r4nanconv_il_d and JIT/Methodical/NaN/r4nanconv_il_r should not run on Linux arm64 as they are disabled twice in the issues.targets file:

  • under Condition=" '$(RuntimeFlavor)' == 'mono' and '$(TargetArchitecture)' == 'arm64' and '$(TargetsWindows)' != 'true' "
  • under Condition="'$(RuntimeFlavor)' == 'mono' and '$(RuntimeVariant)' == 'monointerpreter' "

But based on #65681 (comment), they still run.

Author: MaximLipnin
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Feb 22, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Feb 22, 2022
@mdh1418
Copy link
Member

mdh1418 commented Feb 22, 2022

Looking at the Wrappers.Linux.arm64.Release.binlog (obtained from https://dev.azure.com/dnceng/public/_build/results?buildId=1625063&view=artifacts&pathAsName=false&type=publishedArtifacts in mono_monointerpreter_TestRunLogs_Linux_arm64_release_innerloop), I haven't found r4NaNconv_il_d under an ExcludeList, but I did find overflow04_div under an ExcludeList (theres only one overflow04_div in the issues.targets and its under monointerp and mono)

@EgorBo
Copy link
Member

EgorBo commented Jun 11, 2022

I assume the test was fixed via #65681

@EgorBo EgorBo closed this as completed Jun 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@EgorBo @MaximLipnin @mdh1418 @JulieLeeMSFT