Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review workaround for ProcessEvent when event source is disabled #65938

Open
jeffhandley opened this issue Feb 27, 2022 · 2 comments
Open

Review workaround for ProcessEvent when event source is disabled #65938

jeffhandley opened this issue Feb 27, 2022 · 2 comments

Comments

@jeffhandley
Copy link
Member

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround that was applied to ProcessEvent for when event source is disabled via a feature switch. The comment indicates the "simple fix" should be reconsidered once #43657 is done. That issue has been closed, but it's unclear if this workaround is still necessary.

{
// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
if (!IsSupported)
{

The applied fix should be reconsidered per the comment to determine if a different fix should be made. With the findings we should either apply a different fix, update the comment to reflect it's a permanent fix as-is, or update the code comment to reference this open issue for tracking.

/cc @deeprobin

@ghost
Copy link

ghost commented Feb 27, 2022

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Cleanup Issue-URLs in Code · Issue #63902 · dotnet/runtime identified a workaround that was applied to ProcessEvent for when event source is disabled via a feature switch. The comment indicates the "simple fix" should be reconsidered once #43657 is done. That issue has been closed, but it's unclear if this workaround is still necessary.

{
// A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch.
// Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done.
if (!IsSupported)
{

The applied fix should be reconsidered per the comment to determine if a different fix should be made. With the findings we should either apply a different fix, update the comment to reflect it's a permanent fix as-is, or update the code comment to reference this open issue for tracking.

/cc @deeprobin

Author: jeffhandley
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 27, 2022
@tommcdon
Copy link
Member

@hoyosjs

@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Feb 28, 2022
@tommcdon tommcdon added this to the 7.0.0 milestone Feb 28, 2022
@tommcdon tommcdon modified the milestones: 7.0.0, Future May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants