-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Use a fixed version of v8
, and chrome for testing
#66164
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsCurrently we use
cc @kg @pavelsavara @radekdoulik @lewing
|
We need to make it easy to bypass the version check in xharness (for regression tests/bisecting) but I think it's worthwhile to at least warn if the version is too old. |
I'll make the default behavior to only warn if the version is different. And for CI runs we can opt-in to getting an error. |
I started working on this, but it will be a lot of work which will get dropped in the future. And trying to provision on every CI build has other issues too, like just random network failures would cause tests to not run at all. cc @akoeplinger |
Re-opened because some of the TODO items would still be useful |
@radekdoulik could you please update the V8 version in the images used for helix, to the latest stable one? |
v8
for testingv8
, and chrome for testing
It is not quite feasible right now to automatically enforce a fixed version across all the places v8 gets used. This is a manual process for now. Short of that, a useful measure would be to at least make it easy to answer "which version of v8 is being used for testing"? And add info on where this needs to be changed when it is updated. The case of chrome is fixed though, it uses the latest stable version, or falls back to the closest one in case we fail to find a snapshot for the latest version. |
We are now using a fixed v8, and chrome version across CI, except for runtime tests. |
Currently we use
v8
on helix from the image itself, unlike chrome, for which we send a specific version as a payload.Update to use that version for helixChrome version is fixed, change that back to using the latest stable:
cc @kg @pavelsavara @radekdoulik @lewing
The text was updated successfully, but these errors were encountered: