Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Use a fixed version of v8, and chrome for testing #66164

Open
8 of 9 tasks
radical opened this issue Mar 3, 2022 · 8 comments
Open
8 of 9 tasks

[wasm] Use a fixed version of v8, and chrome for testing #66164

radical opened this issue Mar 3, 2022 · 8 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone

Comments

@radical
Copy link
Member

radical commented Mar 3, 2022

Currently we use v8 on helix from the image itself, unlike chrome, for which we send a specific version as a payload.

  • determine a version to use
  • Update helix images to use the latest stable version Update to use that version for helix
  • Match this for codespaces too - This is installed by the build now.
  • Should we also be checking a minimum version in xharness? - not enforcing this.
  • Use the specific version of v8 for runtime tests also
  • print the version in xharness
  • perf pipeline should also follow this (fixed version right now)

Chrome version is fixed, change that back to using the latest stable:

  • figure out a dependable way of getting the version, and matching binaries
  • Add a fallback to the closest previous version in case the latest stable one cannot be obtained.

cc @kg @pavelsavara @radekdoulik @lewing

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Mar 3, 2022
@ghost
Copy link

ghost commented Mar 3, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently we use v8 on helix from the image itself, unlike chrome, for which we send a specific version as a payload.

  • determine a version to use
  • Update to use that version for helix
  • Match this for codespaces too
  • Should we also be checking a minimum version in xharness?

cc @kg @pavelsavara @radekdoulik @lewing

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 3, 2022
@radical radical removed the untriaged New issue has not been triaged by the area owner label Mar 3, 2022
@kg
Copy link
Member

kg commented Mar 4, 2022

We need to make it easy to bypass the version check in xharness (for regression tests/bisecting) but I think it's worthwhile to at least warn if the version is too old.

@radical
Copy link
Member Author

radical commented Nov 1, 2022

We need to make it easy to bypass the version check in xharness (for regression tests/bisecting) but I think it's worthwhile to at least warn if the version is too old.

I'll make the default behavior to only warn if the version is different. And for CI runs we can opt-in to getting an error.

@radical
Copy link
Member Author

radical commented Nov 3, 2022

I started working on this, but it will be a lot of work which will get dropped in the future. And trying to provision on every CI build has other issues too, like just random network failures would cause tests to not run at all.
Instead, we'll update the V8 version in the helix images for now, and update the version hardcoded in other places.

cc @akoeplinger

@radical radical closed this as completed Nov 3, 2022
@radical radical reopened this Nov 3, 2022
@radical
Copy link
Member Author

radical commented Nov 3, 2022

Re-opened because some of the TODO items would still be useful

@radical
Copy link
Member Author

radical commented Nov 3, 2022

@radekdoulik could you please update the V8 version in the images used for helix, to the latest stable one?

@radical radical changed the title [wasm] Use a fixed version of v8 for testing [wasm] Use a fixed version of v8, and chrome for testing Dec 14, 2022
@radical
Copy link
Member Author

radical commented Jul 25, 2023

It is not quite feasible right now to automatically enforce a fixed version across all the places v8 gets used. This is a manual process for now. Short of that, a useful measure would be to at least make it easy to answer "which version of v8 is being used for testing"? And add info on where this needs to be changed when it is updated.

The case of chrome is fixed though, it uses the latest stable version, or falls back to the closest one in case we fail to find a snapshot for the latest version.

@radical radical modified the milestones: 8.0.0, 9.0.0 Jul 25, 2023
@radical
Copy link
Member Author

radical commented Oct 23, 2023

We are now using a fixed v8, and chrome version across CI, except for runtime tests.

@radical radical removed their assignment Mar 21, 2024
@lewing lewing modified the milestones: 9.0.0, Future Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

No branches or pull requests

4 participants