Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Move to Windows.10.Amd64.Server2022.ES.Open to 6.0 #67048

Closed
CarnaViire opened this issue Mar 23, 2022 · 8 comments
Closed

Backport Move to Windows.10.Amd64.Server2022.ES.Open to 6.0 #67048

CarnaViire opened this issue Mar 23, 2022 · 8 comments

Comments

@CarnaViire
Copy link
Member

CI in backport PRs are now failing because Windows.10.Amd64.Server19H1.ES.Open is reaching EOL, example: https://dev.azure.com/dnceng/public/_build/results?buildId=1674630&view=logs&j=457f7e88-dfa2-5bd9-f871-fdf124c2477d&t=bfe52dfb-2099-5c7f-ee52-70a1d81c544e&l=53
##[error]SENDHELIXJOB(0,0): error : Helix queue windows.10.amd64.server19h1.es.open is set for estimated removal date of 2022-03-31. In most cases the queue will be removed permanently due to end-of-life; please contact dnceng for any questions or concerns, and we can help you decide how to proceed and discuss other options.
Please backport #66404 to 6.0

@danmoseley
Copy link
Member

cc @elinor-fung

@CarnaViire
Copy link
Member Author

citing @MattGal

[4:18 PM] Matt Galbraith
I would certainly recommend such a backport. You just need the changes in https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/templates/runtimes/send-to-helix-inner-step.yml#L17 and https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/templates/runtimes/send-to-helix-inner-step.yml#L25 I believe

​[4:21 PM] Matt Galbraith
One other thing to consider for release branches is a property I added called "FailOnMissingTargetQueue"

​[4:22 PM] Matt Galbraith
it's true by default (https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/Sdk/HelixTask.cs#L29) but if you set it to false, it will downgrade removed queues to warnings allowing you to ignore expiring helix jobs as long as you still send to 1+ remaining queues

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 23, 2022
@ghost
Copy link

ghost commented Mar 23, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

CI in backport PRs are now failing because Windows.10.Amd64.Server19H1.ES.Open is reaching EOL, example: https://dev.azure.com/dnceng/public/_build/results?buildId=1674630&view=logs&j=457f7e88-dfa2-5bd9-f871-fdf124c2477d&t=bfe52dfb-2099-5c7f-ee52-70a1d81c544e&l=53
##[error]SENDHELIXJOB(0,0): error : Helix queue windows.10.amd64.server19h1.es.open is set for estimated removal date of 2022-03-31. In most cases the queue will be removed permanently due to end-of-life; please contact dnceng for any questions or concerns, and we can help you decide how to proceed and discuss other options.
Please backport #66404 to 6.0

Author: CarnaViire
Assignees: -
Labels:

area-Infrastructure, untriaged

Milestone: -

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 23, 2022
@elinor-fung
Copy link
Member

elinor-fung commented Mar 24, 2022

Ah, in order to be clean running on Server 2022, we'd also need to backport all the System.Net test fixes... cc @wfurt

@wfurt
Copy link
Member

wfurt commented Mar 24, 2022

We did port back some but I'm not sure if all. That can probably done quickly if/when 6.0 branch is open again.

@elinor-fung
Copy link
Member

Oh, I might be getting confused between #58927 and the other System.Net test failures we had on Server 2022. All the failures hit in #67054 look like #58927.

@wfurt
Copy link
Member

wfurt commented Mar 24, 2022

It seems like we need #64968 @elinor-fung. It seems like I started back then but it never finished after automatic back-port failed ;(
And yes, the base issue is #58927 - something Windows is trying to fix. The reason why Server 2022 had more failures when introduced lives in fact that the image we use is significantly modified by Azure (for security reasons)

@elinor-fung
Copy link
Member

The backport was merged at the beginning of this month.

@jeffhandley jeffhandley removed the untriaged New issue has not been triaged by the area owner label May 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants