Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM64 - GT_MADD - do not emit 'msub' in code-gen #67869

Closed
TIHan opened this issue Apr 11, 2022 · 3 comments
Closed

ARM64 - GT_MADD - do not emit 'msub' in code-gen #67869

TIHan opened this issue Apr 11, 2022 · 3 comments
Assignees
@TIHan
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@TIHan
Copy link
Contributor

TIHan commented Apr 11, 2022

At the moment, GT_MADD op can emit 'msub' - since we are adding GT_MSUB, we should remove this behavior and instead make the decision to emit 'msub' by using GT_MSUB in lowering.
@TIHan TIHan self-assigned this Apr 11, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Apr 11, 2022
@ghost
Copy link

ghost commented Apr 11, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

At the moment, GT_MADD op can emit 'msub' - since we are adding GT_MSUB, we should remove this behavior and instead make the decision to emit 'msub' by using GT_MSUB in lowering.

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@TIHan TIHan mentioned this issue Apr 11, 2022
Merged
1 task
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Apr 11, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the Future milestone Apr 11, 2022
@JulieLeeMSFT
Copy link
Member

@TIHan please change to .NET 7 from future if you get to work on it.

@TIHan TIHan modified the milestones: Future, 7.0.0 Apr 12, 2022
@TIHan TIHan mentioned this issue Apr 15, 2022
Closed
1 task
@TIHan
Copy link
Contributor Author

TIHan commented Jun 6, 2022

This was resolved by: #68363

@TIHan TIHan closed this as completed Jun 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TIHan TIHan

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@TIHan @JulieLeeMSFT