Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions in System.Tests.Perf_Array for ARM64 #68667

Closed
performanceautofiler bot opened this issue Apr 28, 2022 · 9 comments
Closed

Regressions in System.Tests.Perf_Array for ARM64 #68667

performanceautofiler bot opened this issue Apr 28, 2022 · 9 comments
Labels
arch-arm64 area-System.Memory help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
7.0.0

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline b42adaddff9047e32c9d7f4145746dbb579758f2
Compare ae9f1ca5717045293f726877de18a8f6cf792c5b
Diff Diff

Regressions in System.Tests.Perf_Array

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Reverse - Duration of single invocation 86.87 ns 141.59 ns 1.63 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Tests.Perf_Array*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Array.Reverse

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 141.5902091930573 > 91.26066230361728.
IsChangePoint: Marked as a change because one of 4/26/2022 6:18:08 AM, 4/27/2022 8:46:50 AM falls between 4/19/2022 6:32:34 PM and 4/27/2022 8:46:50 AM.
IsRegressionStdDev: Marked as regression because -131.54038213427378 (T) = (0 -142.15692031098698) / Math.Sqrt((0.22062057934126858 / (35)) + (0.5115350008666868 / (3))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (3) - 2, .025) and -0.6369040400935537 = (86.84499324887872 - 142.15692031098698) / 86.84499324887872 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture arm64
OS Windows 10.0.19041
Baseline b42adaddff9047e32c9d7f4145746dbb579758f2
Compare ae9f1ca5717045293f726877de18a8f6cf792c5b
Diff Diff

Regressions in System.Memory.Span<Char>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Reverse - Duration of single invocation 171.70 ns 286.87 ns 1.67 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Memory.Span&lt;Char&gt;*'

Payloads

Baseline
Compare

Histogram

System.Memory.Span<Char>.Reverse(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 286.8743261808392 > 180.59975390646315.
IsChangePoint: Marked as a change because one of 4/26/2022 6:18:08 AM, 4/27/2022 8:46:50 AM falls between 4/19/2022 6:32:34 PM and 4/27/2022 8:46:50 AM.
IsRegressionStdDev: Marked as regression because -227.30060518890855 (T) = (0 -286.39017242473375) / Math.Sqrt((1.9498782004738482 / (35)) + (0.5830247902076874 / (3))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (3) - 2, .025) and -0.6580417757183983 = (172.72795934266873 - 286.39017242473375) / 172.72795934266873 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline b42adaddff9047e32c9d7f4145746dbb579758f2
Compare ae9f1ca5717045293f726877de18a8f6cf792c5b
Diff Diff

Regressions in System.Memory.Span<Byte>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Reverse - Duration of single invocation 173.49 ns 236.54 ns 1.36 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Memory.Span&lt;Byte&gt;*'

Payloads

Baseline
Compare

Histogram

System.Memory.Span<Byte>.Reverse(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 236.54396131211246 > 182.10393200384888.
IsChangePoint: Marked as a change because one of 4/26/2022 6:18:08 AM, 4/27/2022 8:46:50 AM falls between 4/19/2022 6:32:34 PM and 4/27/2022 8:46:50 AM.
IsRegressionStdDev: Marked as regression because -126.16357924033326 (T) = (0 -236.0946824240651) / Math.Sqrt((1.7492659048874621 / (35)) + (0.6067386409791822 / (3))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (3) - 2, .025) and -0.3668204454251107 = (172.73277058028975 - 236.0946824240651) / 172.73277058028975 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arm64 untriaged New issue has not been triaged by the area owner labels Apr 28, 2022
@AndyAyersMS
Copy link
Member

Looks like #64412.

@AndyAyersMS AndyAyersMS transferred this issue from dotnet/perf-autofiling-issues Apr 28, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@AndyAyersMS AndyAyersMS changed the title [Perf] Changes at 4/26/2022 10:28:11 AM Regressions in System.Tests.Perf_Array for ARM64 Apr 28, 2022
@AndyAyersMS AndyAyersMS added arch-arm64 tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark area-System.Memory labels Apr 28, 2022
@ghost
Copy link

ghost commented Apr 28, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline b42adaddff9047e32c9d7f4145746dbb579758f2
Compare ae9f1ca5717045293f726877de18a8f6cf792c5b
Diff Diff

Regressions in System.Tests.Perf_Array

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Reverse - Duration of single invocation 86.87 ns 141.59 ns 1.63 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Tests.Perf_Array*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Array.Reverse

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 141.5902091930573 > 91.26066230361728.
IsChangePoint: Marked as a change because one of 4/26/2022 6:18:08 AM, 4/27/2022 8:46:50 AM falls between 4/19/2022 6:32:34 PM and 4/27/2022 8:46:50 AM.
IsRegressionStdDev: Marked as regression because -131.54038213427378 (T) = (0 -142.15692031098698) / Math.Sqrt((0.22062057934126858 / (35)) + (0.5115350008666868 / (3))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (3) - 2, .025) and -0.6369040400935537 = (86.84499324887872 - 142.15692031098698) / 86.84499324887872 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture arm64
OS Windows 10.0.19041
Baseline b42adaddff9047e32c9d7f4145746dbb579758f2
Compare ae9f1ca5717045293f726877de18a8f6cf792c5b
Diff Diff

Regressions in System.Memory.Span<Char>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Reverse - Duration of single invocation 171.70 ns 286.87 ns 1.67 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Memory.Span&lt;Char&gt;*'

Payloads

Baseline
Compare

Histogram

System.Memory.Span<Char>.Reverse(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 286.8743261808392 > 180.59975390646315.
IsChangePoint: Marked as a change because one of 4/26/2022 6:18:08 AM, 4/27/2022 8:46:50 AM falls between 4/19/2022 6:32:34 PM and 4/27/2022 8:46:50 AM.
IsRegressionStdDev: Marked as regression because -227.30060518890855 (T) = (0 -286.39017242473375) / Math.Sqrt((1.9498782004738482 / (35)) + (0.5830247902076874 / (3))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (3) - 2, .025) and -0.6580417757183983 = (172.72795934266873 - 286.39017242473375) / 172.72795934266873 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline b42adaddff9047e32c9d7f4145746dbb579758f2
Compare ae9f1ca5717045293f726877de18a8f6cf792c5b
Diff Diff

Regressions in System.Memory.Span<Byte>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Reverse - Duration of single invocation 173.49 ns 236.54 ns 1.36 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Memory.Span&lt;Byte&gt;*'

Payloads

Baseline
Compare

Histogram

System.Memory.Span<Byte>.Reverse(Size: 512)

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 236.54396131211246 > 182.10393200384888.
IsChangePoint: Marked as a change because one of 4/26/2022 6:18:08 AM, 4/27/2022 8:46:50 AM falls between 4/19/2022 6:32:34 PM and 4/27/2022 8:46:50 AM.
IsRegressionStdDev: Marked as regression because -126.16357924033326 (T) = (0 -236.0946824240651) / Math.Sqrt((1.7492659048874621 / (35)) + (0.6067386409791822 / (3))) is less than -2.028094000977961 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (3) - 2, .025) and -0.3668204454251107 = (172.73277058028975 - 236.0946824240651) / 172.73277058028975 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

arch-arm64, area-System.Memory, tenet-performance, tenet-performance-benchmarks, untriaged
Milestone: -

@AndyAyersMS
Copy link
Member

Also dotnet/perf-autofiling-issues#4998

@danmoseley
Copy link
Member

cc @alexcovington

@lewing
Copy link
Member

lewing commented May 3, 2022

also hit wasm dotnet/perf-autofiling-issues#5014

@lewing
Copy link
Member

lewing commented May 5, 2022 •
edited
Loading

it is a 3x regression on wasm

@adamsitnik adamsitnik added help wanted [up-for-grabs] Good issue for external contributors and removed untriaged New issue has not been triaged by the area owner labels May 9, 2022
@adamsitnik adamsitnik added this to the 7.0.0 milestone May 9, 2022
@lewing lewing mentioned this issue Jun 8, 2022
Closed
@dakersnar dakersnar mentioned this issue Jun 8, 2022
Merged
@dakersnar
Copy link
Contributor

These regressions show up in the preview 5 perf report. See my comment here: #64412 (comment)

@dakersnar dakersnar mentioned this issue Jun 10, 2022
Closed
14 tasks
@jkotas jkotas mentioned this issue Jun 13, 2022
Merged
@yesmey yesmey mentioned this issue Jun 18, 2022
Merged
@adamsitnik
Copy link
Member

#70650 has fixed the issue:

image

historical data

@kunalspathak kunalspathak mentioned this issue Jul 7, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm64 area-System.Memory help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
5 participants
@lewing @adamsitnik @danmoseley @AndyAyersMS @dakersnar