Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetYieldProcessorScalingFactor needs to change to adapt to the new periodical measurements #68839

Closed
Maoni0 opened this issue May 3, 2022 · 2 comments
Closed

SetYieldProcessorScalingFactor needs to change to adapt to the new periodical measurements #68839

Maoni0 opened this issue May 3, 2022 · 2 comments
Labels
area-GC-coreclr
Milestone
7.0.0

Comments

@Maoni0
Copy link
Member

Maoni0 commented May 3, 2022

unfortunately I did not see this change (#55295] from last year. this means we'd need to change our implementation of SetYieldProcessorScalingFactor, ie, no longer assuming this will only ever be called once. credit to @sergiy-k who observed this and informed me of it. the fix should be backported to 6.0.
@Maoni0 Maoni0 added this to the 7.0.0 milestone May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

unfortunately I did not see this change (#55295] from last year. this means we'd need to change our implementation of SetYieldProcessorScalingFactor, ie, no longer assuming this will only ever be called once. credit to @sergiy-k who observed this and informed me of it. the fix should be backported to 6.0.

Author: Maoni0
Assignees: -
Labels:

area-GC-coreclr
Milestone: 7.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 3, 2022
@Maoni0 Maoni0 removed the untriaged New issue has not been triaged by the area owner label May 3, 2022
This was referenced May 4, 2022
Merged
Merged
@Maoni0
Copy link
Member Author

Maoni0 commented May 5, 2022

fixed by #68879 and #68881

@Maoni0 Maoni0 closed this as completed May 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-GC-coreclr
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@Maoni0