Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][iOS] Enable HttpClientHandler.DangerousAcceptAnyServerCertificateValidator when using native handlers #68898

Closed
simonrozsival opened this issue May 5, 2022 · 2 comments · Fixed by #73763
Closed

[Android][iOS] Enable HttpClientHandler.DangerousAcceptAnyServerCertificateValidator when using native handlers #68898

simonrozsival opened this issue May 5, 2022 · 2 comments · Fixed by #73763
Labels
area-System.Net.Http blocked Issue/PR is blocked on something - see comments enhancement Product code improvement that does NOT require public API changes/additions os-android os-ios Apple iOS
Milestone
7.0.0

Comments

@simonrozsival
Copy link
Member

At the moment the HttpClientHandler.DangerousAcceptAnyServerCertificateValidator property throws PlatformNotSupportedException when using native handlers. Since the native handlers will use the ServerCertificateCustomValidationCallback property in .NET 7 (see dotnet/android#6665, mac/iOS is implementation is currently in progress) there won't be a reason to throw the exception anymore.

/cc @akoeplinger
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 5, 2022
@ghost
Copy link

ghost commented May 5, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

At the moment the HttpClientHandler.DangerousAcceptAnyServerCertificateValidator property throws PlatformNotSupportedException when using native handlers. Since the native handlers will use the ServerCertificateCustomValidationCallback property in .NET 7 (see dotnet/android#6665, mac/iOS is implementation is currently in progress) there won't be a reason to throw the exception anymore.

/cc @akoeplinger

Author: simonrozsival
Assignees: -
Labels:

area-System.Net.Http, os-android, os-ios
Milestone: -

@karelz
Copy link
Member

karelz commented May 17, 2022

@simonrozsival can you please triage the issue?

@simonrozsival simonrozsival added this to the Future milestone May 24, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 24, 2022
@simonrozsival simonrozsival added enhancement Product code improvement that does NOT require public API changes/additions blocked Issue/PR is blocked on something - see comments untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels May 24, 2022
@simonrozsival simonrozsival mentioned this issue May 25, 2022
Merged
@Eagle3386 Eagle3386 mentioned this issue Jun 15, 2022
Closed
@simonrozsival simonrozsival mentioned this issue Aug 11, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2022
@karelz karelz modified the milestones: Future, 7.0.0 Aug 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Http blocked Issue/PR is blocked on something - see comments enhancement Product code improvement that does NOT require public API changes/additions os-android os-ios Apple iOS
Projects
None yet
Milestone
7.0.0
2 participants
@simonrozsival @karelz