Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM32: Assertion failed 'varDsc->lvType == TYP_STRUCT' in 'System.SpanHelpers:Fill(byref,int,System.__Canon)' during 'Generate code' in jitminopts runs #69350

Closed
jakobbotsch opened this issue May 14, 2022 · 5 comments · Fixed by #69354
Assignees
Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Milestone

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented May 14, 2022

Pipeline run: https://dev.azure.com/dnceng/public/_build/results?buildId=1770681&view=results
Job: coreclr Linux arm Checked jitminopts

        Assert failure(PID 528 [0x00000210], Thread: 528 [0x0210]): Assertion failed 'varDsc->lvType == TYP_STRUCT' in 'System.SpanHelpers:Fill(byref,int,System.__Canon)' during 'Generate code' (IL size 911; hash 0xc319f39c; MinOpts)
        
            File: /__w/1/s/src/coreclr/jit/codegenarmarch.cpp Line: 1306
            Image: /root/helix/work/correlation/corerun

Introduced in range 72f9cb2d..6f15fdc8

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 14, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 14, 2022
@ghost
Copy link

ghost commented May 14, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Pipeline run: https://dev.azure.com/dnceng/public/_build/results?buildId=1770681&view=results
Job: coreclr Linux arm Checked jitminopts

        Assert failure(PID 528 [0x00000210], Thread: 528 [0x0210]): Assertion failed 'varDsc->lvType == TYP_STRUCT' in 'System.SpanHelpers:Fill(byref,int,System.__Canon)' during 'Generate code' (IL size 911; hash 0xc319f39c; MinOpts)
        
            File: /__w/1/s/src/coreclr/jit/codegenarmarch.cpp Line: 1306
            Image: /root/helix/work/correlation/corerun

Introduced in range 72f9cb2..6f15fdc

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@jakobbotsch
Copy link
Member Author

Repros in arm32 altjit for

public static void Main()
{
    Span<object> foo = new object[1000];
    foo.Fill(null);
}

with COMPlus_JITMinOpts=1

@jakobbotsch
Copy link
Member Author

Bisected this to #68739, cc @dotnet/jit-contrib @tannergooding

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label May 14, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone May 14, 2022
@tannergooding
Copy link
Member

I wonder if this is handled by @SingleAccretion's PR: #69271

It might also be a different issue and in need of its own work item/fix.

@SingleAccretion
Copy link
Contributor

I will investigate this; on first approximation the assert looks questionable because there is no requirement for the underlying local and the OBJ on top of it to match (there is a similarly questionable assert(!varDsc->lvIsHfa()) assert below).

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 14, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants