Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tar tests that interact with file assets do not work on Browser #69953

Open
carlossanlop opened this issue May 28, 2022 · 3 comments
Open

Tar tests that interact with file assets do not work on Browser #69953

carlossanlop opened this issue May 28, 2022 · 3 comments
Assignees
@carlossanlop
Labels
arch-wasm WebAssembly architecture area-System.Formats.Tar
Milestone
Future

Comments

@carlossanlop
Copy link
Member

In this PR resubmission I added the missing Browser target platform in the tests project, and the result was that the browser tests that need to read file assets do not work on WASM.

Those test classes that read file assets will be topped with the ActiveIssue attribute and will be linked to this issue for future investigation, to unblock merging that PR.

Log1, log2

Here's an output example of one of the browser CI legs:

[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(includeBaseDirectory: False)
[02:30:29] info: Assert.NotNull() Failure
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(includeBaseDirectory: True)
[02:30:29] info: Assert.NotNull() Failure
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: False)
[02:30:29] info: Assert.Equal() Failure
[02:30:29] info: Expected: 3
[02:30:29] info: Actual:   0
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: True)
[02:30:29] info: Assert.Equal() Failure
[02:30:29] info: Expected: 3
[02:30:29] info: Actual:   0
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: 2
[02:30:30] info: Actual:   1
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_LinkEntry_TargetInsideDirectory_Internal(TarEntryType entryType)
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarFile_ExtractToDirectory_File_Tests.Extract_SpecialFiles_Unix_Unelevated_ThrowsUnauthorizedAccess
[02:30:30] info: Assert.Throws() Failure
[02:30:30] info: Expected: typeof(System.UnauthorizedAccessException)
[02:30:30] info: Actual:   (No exception was thrown)
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_File_Tests.Extract_SpecialFiles_Unix_Unelevated_ThrowsUnauthorizedAccess()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.EntryName_NullOrEmpty
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.EntryName_NullOrEmpty()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: V7
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: V7
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Ustar
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Ustar
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Pax
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Pax
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Gnu
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Gnu
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: V7)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Ustar)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Pax)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] info: Finished:    System.Formats.Tar.Tests.dll
@carlossanlop carlossanlop added this to the 7.0.0 milestone May 28, 2022
@carlossanlop carlossanlop self-assigned this May 28, 2022
@ghost
Copy link

ghost commented May 28, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

In this PR resubmission I added the missing Browser target platform in the tests project, and the result was that the browser tests that need to read file assets do not work on WASM.

Those test classes that read file assets will be topped with the ActiveIssue attribute and will be linked to this issue for future investigation, to unblock merging that PR.

Log1, log2

Here's an output example of one of the browser CI legs:

[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(includeBaseDirectory: False)
[02:30:29] info: Assert.NotNull() Failure
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(includeBaseDirectory: True)
[02:30:29] info: Assert.NotNull() Failure
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: False)
[02:30:29] info: Assert.Equal() Failure
[02:30:29] info: Expected: 3
[02:30:29] info: Actual:   0
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: True)
[02:30:29] info: Assert.Equal() Failure
[02:30:29] info: Expected: 3
[02:30:29] info: Actual:   0
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: 2
[02:30:30] info: Actual:   1
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_LinkEntry_TargetInsideDirectory_Internal(TarEntryType entryType)
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarFile_ExtractToDirectory_File_Tests.Extract_SpecialFiles_Unix_Unelevated_ThrowsUnauthorizedAccess
[02:30:30] info: Assert.Throws() Failure
[02:30:30] info: Expected: typeof(System.UnauthorizedAccessException)
[02:30:30] info: Actual:   (No exception was thrown)
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_File_Tests.Extract_SpecialFiles_Unix_Unelevated_ThrowsUnauthorizedAccess()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.EntryName_NullOrEmpty
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.EntryName_NullOrEmpty()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: V7
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: V7
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Ustar
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Ustar
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Pax
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Pax
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Gnu
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Gnu
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: V7)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Ustar)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Pax)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] info: Finished:    System.Formats.Tar.Tests.dll
Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.IO
Milestone: 7.0.0

@carlossanlop carlossanlop mentioned this issue May 28, 2022
Merged
@radical
Copy link
Member

radical commented May 31, 2022

@carlossanlop you can surface files to the wasm app by using <WasmFilesToIncludeInFileSystem Include="..." />

@radical radical added the arch-wasm WebAssembly architecture label May 31, 2022
@ghost
Copy link

ghost commented May 31, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In this PR resubmission I added the missing Browser target platform in the tests project, and the result was that the browser tests that need to read file assets do not work on WASM.

Those test classes that read file assets will be topped with the ActiveIssue attribute and will be linked to this issue for future investigation, to unblock merging that PR.

Log1, log2

Here's an output example of one of the browser CI legs:

[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(includeBaseDirectory: False)
[02:30:29] info: Assert.NotNull() Failure
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(includeBaseDirectory: True)
[02:30:29] info: Assert.NotNull() Failure
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.IncludeAllSegmentsOfPath(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: False)
[02:30:29] info: Assert.Equal() Failure
[02:30:29] info: Expected: 3
[02:30:29] info: Actual:   0
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:29] fail: [FAIL] System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(includeBaseDirectory: True)
[02:30:29] info: Assert.Equal() Failure
[02:30:29] info: Expected: 3
[02:30:29] info: Actual:   0
[02:30:29] info:    at System.Formats.Tar.Tests.TarFile_CreateFromDirectory_File_Tests.VerifyIncludeBaseDirectory(Boolean includeBaseDirectory)
[02:30:29] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: 2
[02:30:30] info: Actual:   1
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_LinkEntry_TargetInsideDirectory_Internal(TarEntryType entryType)
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_Stream_Tests.Extract_HardLinkEntry_TargetInsideDirectory()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarFile_ExtractToDirectory_File_Tests.Extract_SpecialFiles_Unix_Unelevated_ThrowsUnauthorizedAccess
[02:30:30] info: Assert.Throws() Failure
[02:30:30] info: Expected: typeof(System.UnauthorizedAccessException)
[02:30:30] info: Actual:   (No exception was thrown)
[02:30:30] info:    at System.Formats.Tar.Tests.TarFile_ExtractToDirectory_File_Tests.Extract_SpecialFiles_Unix_Unelevated_ThrowsUnauthorizedAccess()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.EntryName_NullOrEmpty
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.EntryName_NullOrEmpty()
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: V7
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: V7, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: V7
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Ustar
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Ustar, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Ustar
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Pax
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Pax, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Pax
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: False)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Gnu
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(format: Gnu, withContents: True)
[02:30:30] info: Assert.Equal() Failure
[02:30:30] info: Expected: Gnu
[02:30:30] info: Actual:   Unknown
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_Directory(TarFormat format, Boolean withContents)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: V7)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Ustar)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Pax)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] fail: [FAIL] System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(format: Gnu)
[02:30:30] info: Assert.NotNull() Failure
[02:30:30] info:    at System.Formats.Tar.Tests.TarWriter_WriteEntry_File_Tests.Add_File(TarFormat format)
[02:30:30] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)
[02:30:30] info: Finished:    System.Formats.Tar.Tests.dll
Author: carlossanlop
Assignees: carlossanlop
Labels:

arch-wasm, area-System.IO
Milestone: 7.0.0

@lewing lewing modified the milestones: 7.0.0, 8.0.0 Jul 26, 2022
@carlossanlop carlossanlop modified the milestones: 8.0.0, Future Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlossanlop carlossanlop

Labels
arch-wasm WebAssembly architecture area-System.Formats.Tar
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@radical @lewing @carlossanlop