Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 5/23/2022 10:48:42 PM #70027

Closed
performanceautofiler bot opened this issue May 31, 2022 · 3 comments
Closed

[Perf] Changes at 5/23/2022 10:48:42 PM #70027

performanceautofiler bot opened this issue May 31, 2022 · 3 comments
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) PGO runtime-coreclr specific to the CoreCLR runtime
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS ubuntu 18.04
Baseline ff5840bbe619e74502e0c8466153e233a2ec6dc5
Compare 110b4cfaa627deed4b06b864b06128267d0a64c2
Diff Diff

Regressions in Benchstone.BenchF.LLoops

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Test - Duration of single invocation 499.80 ms 549.17 ms 1.10 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'Benchstone.BenchF.LLoops*'

Payloads

Baseline
Compare

Histogram

Benchstone.BenchF.LLoops.Test


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 549.1666333571428 > 524.886013701923.
IsChangePoint: Marked as a change because one of 5/11/2022 3:41:15 PM, 5/23/2022 7:50:08 PM, 5/31/2022 8:51:40 AM falls between 5/22/2022 6:37:49 PM and 5/31/2022 8:51:40 AM.
IsRegressionStdDev: Marked as regression because -37.70093537079637 (T) = (0 -542560725.8514153) / Math.Sqrt((15605936918299.818 / (22)) + (16830177370995.5 / (44))) is less than -1.997729654317006 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (22) + (44) - 2, .025) and -0.07829339964985865 = (503166138.2955646 - 542560725.8514153) / 503166138.2955646 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added CoreClr PGO untriaged New issue has not been triaged by the area owner labels May 31, 2022
@tannergooding tannergooding removed the untriaged New issue has not been triaged by the area owner label May 31, 2022
@tannergooding
Copy link
Member

Possibly related #69291

@tannergooding tannergooding transferred this issue from dotnet/perf-autofiling-issues May 31, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 31, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 31, 2022
@ghost
Copy link

ghost commented May 31, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS ubuntu 18.04
Baseline ff5840bbe619e74502e0c8466153e233a2ec6dc5
Compare 110b4cfaa627deed4b06b864b06128267d0a64c2
Diff Diff

Regressions in Benchstone.BenchF.LLoops

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Test - Duration of single invocation 499.80 ms 549.17 ms 1.10 0.00 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'Benchstone.BenchF.LLoops*'

Payloads

Baseline
Compare

Histogram

Benchstone.BenchF.LLoops.Test


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 549.1666333571428 > 524.886013701923.
IsChangePoint: Marked as a change because one of 5/11/2022 3:41:15 PM, 5/23/2022 7:50:08 PM, 5/31/2022 8:51:40 AM falls between 5/22/2022 6:37:49 PM and 5/31/2022 8:51:40 AM.
IsRegressionStdDev: Marked as regression because -37.70093537079637 (T) = (0 -542560725.8514153) / Math.Sqrt((15605936918299.818 / (22)) + (16830177370995.5 / (44))) is less than -1.997729654317006 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (22) + (44) - 2, .025) and -0.07829339964985865 = (503166138.2955646 - 542560725.8514153) / 503166138.2955646 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: tannergooding
Labels:

area-CodeGen-coreclr, untriaged, refs/heads/main, ubuntu 18.04, RunKind=micro, PGO, Regression, CoreClr, x64

Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label May 31, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone May 31, 2022
@AndyAyersMS
Copy link
Member

Perf has since recovered.

Likely #69291 exposed it a latent issue introduced by #68869 that was fixed by #70144. So going to close this one.
newplot - 2022-06-28T132059 690

@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2022
@jeffhandley jeffhandley added runtime-coreclr specific to the CoreCLR runtime os-linux Linux OS (any supported distro) arch-x64 and removed CoreClr labels Dec 28, 2022
@jeffhandley jeffhandley removed the x64 label Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) PGO runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Development

No branches or pull requests

4 participants