Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.Formats.Tar.Tests.Perf_TarFile #70366

Closed
performanceautofiler bot opened this issue Jun 7, 2022 · 6 comments
Closed

Regressions in System.Formats.Tar.Tests.Perf_TarFile #70366

performanceautofiler bot opened this issue Jun 7, 2022 · 6 comments
Assignees
Labels
arch-x64 area-System.Formats.Tar runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS alpine 3.15
Baseline 9d84900aedd34a7d15e2fb8b92614f0429919061
Compare 2f82cb8c2109fe5c9119ed41d7d2c5228cf253ec
Diff Diff

Regressions in System.Formats.Tar.Tests.Perf_TarFile

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateFromDirectory_Stream - Duration of single invocation 28.27 μs 43.89 μs 1.55 0.28 True

Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Formats.Tar.Tests.Perf_TarFile*'

Payloads

Baseline
Compare

Histogram

System.Formats.Tar.Tests.Perf_TarFile.CreateFromDirectory_Stream


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 43.894984671787704 > 30.216427792291704.
IsChangePoint: Marked as a change because one of 6/2/2022 12:41:31 AM, 6/7/2022 9:00:42 AM falls between 5/29/2022 5:15:01 PM and 6/7/2022 9:00:42 AM.
IsRegressionStdDev: Marked as regression because -67.55426562077355 (T) = (0 -44452.910097712476) / Math.Sqrt((1284770.026738758 / (37)) + (539136.6577802796 / (34))) is less than -1.9949454151066512 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (34) - 2, .025) and -0.519244133769709 = (29259.88595882297 - 44452.910097712476) / 29259.88595882297 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added alpine 3.12 untriaged New issue has not been triaged by the area owner labels Jun 7, 2022
@EgorBo EgorBo changed the title [Perf] Changes at 6/2/2022 3:41:19 AM Regressions in System.Formats.Tar.Tests.Perf_TarFile Jun 7, 2022
@EgorBo EgorBo removed the untriaged New issue has not been triaged by the area owner label Jun 7, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@EgorBo EgorBo transferred this issue from dotnet/perf-autofiling-issues Jun 7, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 7, 2022
@EgorBo EgorBo added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Jun 7, 2022
@EgorBo
Copy link
Member

EgorBo commented Jun 7, 2022

Caused by #69469 cc @carlossanlop

@AndyAyersMS
Copy link
Member

Also see dotnet/perf-autofiling-issues#5834

@ghost
Copy link

ghost commented Jun 8, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS alpine 3.15
Baseline 9d84900aedd34a7d15e2fb8b92614f0429919061
Compare 2f82cb8c2109fe5c9119ed41d7d2c5228cf253ec
Diff Diff

Regressions in System.Formats.Tar.Tests.Perf_TarFile

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateFromDirectory_Stream - Duration of single invocation 28.27 μs 43.89 μs 1.55 0.28 True

Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Formats.Tar.Tests.Perf_TarFile*'

Payloads

Baseline
Compare

Histogram

System.Formats.Tar.Tests.Perf_TarFile.CreateFromDirectory_Stream


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 43.894984671787704 > 30.216427792291704.
IsChangePoint: Marked as a change because one of 6/2/2022 12:41:31 AM, 6/7/2022 9:00:42 AM falls between 5/29/2022 5:15:01 PM and 6/7/2022 9:00:42 AM.
IsRegressionStdDev: Marked as regression because -67.55426562077355 (T) = (0 -44452.910097712476) / Math.Sqrt((1284770.026738758 / (37)) + (539136.6577802796 / (34))) is less than -1.9949454151066512 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (34) - 2, .025) and -0.519244133769709 = (29259.88595882297 - 44452.910097712476) / 29259.88595882297 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: AndyAyersMS
Labels:

area-System.IO, tenet-performance, tenet-performance-benchmarks, untriaged, refs/heads/main, RunKind=micro, Regression, CoreClr, x64, alpine 3.12

Milestone: -

@DrewScoggins
Copy link
Member

DrewScoggins commented Jun 9, 2022

@adamsitnik
Copy link
Member

#69469 added some new logic that we just need to perform to be correct, so I am closing this as by design.

@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2022
@jeffhandley jeffhandley added runtime-coreclr specific to the CoreCLR runtime and removed CoreClr labels Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-System.Formats.Tar runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

6 participants