Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize implementation of Array.Fill. #7049

Closed
jamesqo opened this issue Nov 23, 2016 · 6 comments · Fixed by #51365 or #52590
Closed

Optimize implementation of Array.Fill. #7049

jamesqo opened this issue Nov 23, 2016 · 6 comments · Fixed by #51365 or #52590
Labels
area-System.Runtime tenet-performance Performance related issue
Milestone
Future

Comments

@jamesqo
Copy link
Contributor

jamesqo commented Nov 23, 2016

The Array.Fill api which was just added is a very naive implementation. We should look into the perf benefits of implementing it in C++ and doing things like memset for bytes/avoiding multiple type-checks for reference types. Relevant comment: dotnet/coreclr#8137 (comment)
@jamesqo
Copy link
Contributor Author

jamesqo commented Nov 28, 2016

@jnm2 It is going to be done in unmanaged code.

@gkhanna79
Copy link
Member

@danmosemsft PTAL

@kouvel
Copy link
Member

kouvel commented Jul 27, 2017

Could look at Span.Fill as well

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 26, 2020
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Jun 24, 2020
@GrabYourPitchforks GrabYourPitchforks mentioned this issue Apr 16, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 16, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 17, 2021
@xtqqczze
Copy link
Contributor

@GrabYourPitchforks #51365 didn't touch the Array.Fill implementation, should this issue be reopened?

@GrabYourPitchforks
Copy link
Member

@xtqqczze Whoops, good catch.

@ghost
Copy link

ghost commented May 10, 2021

Tagging subscribers to this area: @tannergooding
See info in area-owners.md if you want to be subscribed.

Issue Details

The Array.Fill api which was just added is a very naive implementation. We should look into the perf benefits of implementing it in C++ and doing things like memset for bytes/avoiding multiple type-checks for reference types. Relevant comment: dotnet/coreclr#8137 (comment)

Author: jamesqo
Assignees: -
Labels:

area-System.Runtime, tenet-performance
Milestone: Future

@xtqqczze xtqqczze mentioned this issue May 11, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 11, 2021
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Jun 22, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime tenet-performance Performance related issue
Projects
None yet
Milestone
Future
8 participants
@GrabYourPitchforks @maryamariyan @jamesqo @msftgits @gkhanna79 @layomia @kouvel @xtqqczze