Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm-mt] Revisit the size of pthread pool for CI #75602

Closed
simonrozsival opened this issue Sep 14, 2022 · 3 comments · Fixed by #100415
Closed

[wasm-mt] Revisit the size of pthread pool for CI #75602

simonrozsival opened this issue Sep 14, 2022 · 3 comments · Fixed by #100415
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Milestone

Comments

@simonrozsival
Copy link
Member

simonrozsival commented Sep 14, 2022

Current values are:
pthreadPoolInitialSize = 7
pthreadPoolUnusedSize = 3;

which allows even some very natry threading unit tests to pass.
But WebWorker is expensive resource, especially on Mobile device.
What would be minimum which still works ?

@simonrozsival simonrozsival added arch-wasm WebAssembly architecture area-Build-mono labels Sep 14, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 14, 2022
@ghost
Copy link

ghost commented Sep 14, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In #75286 we increased the size of the pthread pool from the default 4 to 8. This was necessary to make the System.Threading.Tasks.Dataflow.Tests pass. We should revisit this change and determine if it is really necessary and what would be necessary to do to use the default pool size again.

Author: simonrozsival
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@lewing lewing added this to the 8.0.0 milestone Sep 14, 2022
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Sep 14, 2022
@lewing lewing modified the milestones: 8.0.0, 9.0.0 Aug 4, 2023
@pavelsavara
Copy link
Member

navigator.hardwareConcurrency

@pavelsavara
Copy link
Member

pavelsavara commented Jan 26, 2024

How many threads we need:

  • portable timer
  • finalizer
  • there could be GC workers in sgen, I'm not sure about it
  • thread pool, I think there is one "gate" thread and maybe 2 workers
  • we may have debugger thread ?
  • we may have event pipe thread ?
  • we may have sampling profiler ?

@pavelsavara pavelsavara added the os-browser Browser variant of arch-wasm label Jan 29, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Mar 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@github-project-automation github-project-automation bot moved this to Done in wasm-mt Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants