Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update experimental WebAssembly templates to use consistent string quotes in JS #75771

Closed
danroth27 opened this issue Sep 16, 2022 · 2 comments · Fixed by #76182
Closed

Update experimental WebAssembly templates to use consistent string quotes in JS #75771

danroth27 opened this issue Sep 16, 2022 · 2 comments · Fixed by #76182
Assignees
@maraf
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
7.0.x

Comments

@danroth27
Copy link
Member

In main.js, we currently use all three supported string formats: single quotes, double quotes, and back ticks. We should probably use a consistent style.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 16, 2022
@lewing lewing added this to the 7.0.x milestone Sep 16, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 16, 2022
@lewing lewing added the arch-wasm WebAssembly architecture label Sep 16, 2022
@ghost
Copy link

ghost commented Sep 16, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In main.js, we currently use all three supported string formats: single quotes, double quotes, and back ticks. We should probably use a consistent style.

Author: danroth27
Assignees: maraf
Labels:

arch-wasm
Milestone: 7.0.x

@maraf maraf mentioned this issue Sep 26, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 26, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
7.0.x
Development

Successfully merging a pull request may close this issue.

[wasm] Templates nits maraf/runtime
3 participants
@lewing @danroth27 @maraf