-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Net.Quic.Tests.QuicStreamTests.WriteCanceled_NextWriteThrows test failure #76831
Comments
Tagging subscribers to this area: @dotnet/ncl Issue Details
Failed in #76768. Full log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-76768-merge-80851214628f4109bd/System.Net.Quic.Functional.Tests/1/console.21da1d39.log?helixlogtype=result {
"ErrorMessage": "System.Net.Quic.Tests.QuicStreamTests.WriteCanceled_NextWriteThrows",
"BuildRetry": false
}
|
The test is flaky and the failure happens on regular runs as well (but usually succeeds on reruns) The case seems to be when the cancellation happens to occur before the call to WriteAsync (and we call it with pre-cancelled token). runtime/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs Lines 591 to 606 in 844702d
We should have a look someday. |
Okay, my original thought was wrong, we handle precancelled tokens correctly, there is actually very slim chance to repro this because many things have to align properly. the issue can be artificially enforced reproduced by adding sleep in
What happens is that cancellation token sets Write state to cancelled and unblocks the Test task to progress, and it completes the In other words, if cancellation token fires while send is in progress, we may end up gracefully closing the write side :/ |
fixed by #90253 |
Failed in #76768. Full log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-76768-merge-80851214628f4109bd/System.Net.Quic.Functional.Tests/1/console.21da1d39.log?helixlogtype=result
Report
Summary
Known issue validation
Build: 🔎⚠️ Validation could not be done without an Azure DevOps build URL on the issue. Please add it to the "Build: 🔎" line.
Result validation:
The text was updated successfully, but these errors were encountered: