Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Significant Reverse(ReadOnlySpan<byte>) performance regression for certain sizes #78604

Closed
jkotas opened this issue Nov 20, 2022 · 1 comment · Fixed by #78605
Closed

Significant Reverse(ReadOnlySpan<byte>) performance regression for certain sizes #78604

jkotas opened this issue Nov 20, 2022 · 1 comment · Fixed by #78605
Labels
area-System.Memory

Comments

@jkotas
Copy link
Member

jkotas commented Nov 20, 2022 •
edited
Loading

Repro

Run Reverse(ReadOnlySpan<byte>) micro-benchmark (https://github.com/dotnet/performance/blob/c599f4c65e60ffe74c4c959ee02d1dddf551968e/src/benchmarks/micro/libraries/System.Memory/Span.cs#L44) for array size 33.

Result

Current .NET 8 is about 1.6x slower compared to .NET 7 (AVX2 machine)

Introduced by #70944.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 20, 2022
@ghost
Copy link

ghost commented Nov 20, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Reverse(ReadOnlySpan<byte>) micro-benchmark (https://github.com/dotnet/performance/blob/c599f4c65e60ffe74c4c959ee02d1dddf551968e/src/benchmarks/micro/libraries/System.Memory/Span.cs#L44) for array size 33.

Result:

Introduced by #70944. The

Author: jkotas
Assignees: -
Labels:

area-System.Memory, untriaged
Milestone: -

@stephentoub stephentoub mentioned this issue Nov 20, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 20, 2022
@jkotas jkotas mentioned this issue Nov 20, 2022
Merged
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Nov 20, 2022
@adamsitnik adamsitnik mentioned this issue Nov 22, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Memory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Improve Span.Reverse fast path performance" dotnet/runtime
1 participant
@jkotas