Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing custom config binding logic in console logging with use of binding source generator #83598

Closed
layomia opened this issue Mar 17, 2023 · 3 comments
Closed

Consider replacing custom config binding logic in console logging with use of binding source generator #83598

layomia opened this issue Mar 17, 2023 · 3 comments
Assignees
@layomia
Labels
area-Extensions-Logging source-generator Indicates an issue with a source generator feature
Milestone
8.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Mar 17, 2023

Custom logic to replace use of reflection implementation was introduced in #82098.

From @ericstj in #82098 (comment):

@eerhardt would we just replace this with the Configuration Binder source generator generated code once that's ready?

From @eerhardt:

Yes, that is the goal/intention. See #81931 (comment). If/when the Configuration Binder source generator can support this library, we should switch to using it.

Things that may be tricky:

  • netstandard2.0 and netfx support
  • Properties that are annotated with ObsoleteAttribute still need to be bound
  • The mutable struct JsonWriterOptions needs to be supported
@layomia layomia added area-Extensions-Logging size-reduction Issues impacting final app size primary for size sensitive workloads source-generator Indicates an issue with a source generator feature labels Mar 17, 2023
@layomia layomia added this to the 8.0.0 milestone Mar 17, 2023
@ghost
Copy link

ghost commented Mar 17, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Custom logic to replace use of reflection implementation was introduced in #82098.

From @ericstj in #82098 (comment):

@eerhardt would we just replace this with the Configuration Binder source generator generated code once that's ready?

From @eerhardt:

Yes, that is the goal/intention. See #81931 (comment). If/when the Configuration Binder source generator can support this library, we should switch to using it.

Things that may be tricky:

  • netstandard2.0 and netfx support
  • Properties that are annotated with ObsoleteAttribute still need to be bound
  • The mutable struct JsonWriterOptions needs to be supported
Author: layomia
Assignees: -
Labels:

area-Extensions-Logging, size-reduction, source-generator
Milestone: 8.0.0

@ghost
Copy link

ghost commented Mar 17, 2023

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Custom logic to replace use of reflection implementation was introduced in #82098.

From @ericstj in #82098 (comment):

@eerhardt would we just replace this with the Configuration Binder source generator generated code once that's ready?

From @eerhardt:

Yes, that is the goal/intention. See #81931 (comment). If/when the Configuration Binder source generator can support this library, we should switch to using it.

Things that may be tricky:

  • netstandard2.0 and netfx support
  • Properties that are annotated with ObsoleteAttribute still need to be bound
  • The mutable struct JsonWriterOptions needs to be supported
Author: layomia
Assignees: -
Labels:

area-Extensions-Logging, size-reduction, source-generator
Milestone: 8.0.0

@layomia layomia removed the size-reduction Issues impacting final app size primary for size sensitive workloads label Jul 21, 2023
@layomia layomia self-assigned this Jul 21, 2023
@layomia
Copy link
Contributor Author

layomia commented Jul 21, 2023

Fixed in #88067.

@layomia layomia closed this as completed Jul 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-Extensions-Logging source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@layomia