Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Implement Interlocked.ReadMemoryBarrier() #84445

Closed
VSadov opened this issue Apr 6, 2023 · 1 comment · Fixed by #86842
Closed

[NativeAOT] Implement Interlocked.ReadMemoryBarrier() #84445

VSadov opened this issue Apr 6, 2023 · 1 comment · Fixed by #86842
Labels
area-NativeAOT-coreclr

Comments

@VSadov
Copy link
Member

VSadov commented Apr 6, 2023 •
edited
Loading

The CoreCLr implementation was introduced in #35597

The fence must be an intrinsic.

  • on architectures with strong memory ordering (i.e. x64) act as a compiler fence that prevents reordering optimizations.
  • on architectures with weak memory ordering also emit an ordering instruction (i.e. dmb ishld on arm64)

Also consider: #35761
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 6, 2023
@ghost
Copy link

ghost commented Apr 6, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

The CoreCLr implementation was introduced in #35597

The fence must be an intrinsic.

  • on architectures with strong memory ordering (i.e. x64) act as a compiler fence that prevents reordering optimizations.
  • on architectures with weak memory ordering also emit an ordering instruction (i.e. dmb ishld on arm64)
Author: VSadov
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@VSadov VSadov mentioned this issue Apr 6, 2023
Merged
@VSadov VSadov mentioned this issue May 28, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 28, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels May 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NativeAOT] implement Interlocked.ReadMemoryBarrier intrinsic VSadov/runtime
1 participant
@VSadov