Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable relevant thread pool events in Windows #87020

Closed
LakshanF opened this issue Jun 1, 2023 · 6 comments · Fixed by #88894
Closed

Enable relevant thread pool events in Windows #87020

LakshanF opened this issue Jun 1, 2023 · 6 comments · Fixed by #88894

Comments

@LakshanF
Copy link
Member

LakshanF commented Jun 1, 2023

It seems like some IO threadpool events (IOPack, IOEnqueue, and IODequeue) can be enabled for windows in NativeRuntimeEventSource.PortableThreadPool. Given that NativeAOT now has EventPipe, we should do this work to help customers with their diagnostics scenarios.

cc @eduardo-vp, @kouvel

@LakshanF LakshanF added this to the 8.0.0 milestone Jun 1, 2023
@ghost
Copy link

ghost commented Jun 1, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

It seems like some IO threadpool events (IOPack, IOEnqueue, and IODequeue) can be enabled for windows in NativeRuntimeEventSource.PortableThreadPool. Given that NativeAOT now has EventPipe, we should do this work to help customers with their diagnostics scenarios.

cc @eduardo-vp, @kouvel

Author: LakshanF
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: 8.0.0

@kouvel
Copy link
Member

kouvel commented Jul 20, 2023

The portable thread pool implementation should already be raising the events on Windows and Unixes (though last I checked a while back, they weren't working yet). #88894 is adding the raising of some events for the Windows thread pool implementation.

@kouvel
Copy link
Member

kouvel commented Jul 20, 2023

Aside from IOPack, which seemingly is not raised currently on NativeAOT Windows

@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
@LakshanF LakshanF reopened this Jul 12, 2024
@LakshanF
Copy link
Member Author

ThreadPoolIOWork event is not yet working in Windows (either with the UseWindowsThreadPool property set to false or not).

NativeRuntimeEventSourceTest can be used to validate this.

@MichalStrehovsky MichalStrehovsky removed this from the 8.0.0 milestone Jul 12, 2024
@MichalStrehovsky MichalStrehovsky added the untriaged New issue has not been triaged by the area owner label Jul 12, 2024
@MichalStrehovsky
Copy link
Member

I assume we don't want this in the 8.0 milestone that nobody is looking at anymore, so marked this untriaged.

@eduardo-vp
Copy link
Member

The cause of this issue is the same as this one #105556 and was fixed by #106641.

I also verified the test fails before the fix and passes after.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants