Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] NET8 previews performance tracking #88178

Open
radekdoulik opened this issue Jun 29, 2023 · 2 comments
Open

[wasm] NET8 previews performance tracking #88178

radekdoulik opened this issue Jun 29, 2023 · 2 comments
Assignees
Milestone

Comments

@radekdoulik
Copy link
Member

radekdoulik commented Jun 29, 2023

Issues to look at (most important at top):

AOT related issues
dotnet/perf-autofiling-issues#14019 223 regressions, probably AOT and generics
dotnet/perf-autofiling-issues#13755 23 regressions, might show opportunities for SIMD improvements
dotnet/perf-autofiling-issues#19230 3 regressions, utf16 widening code change. It now uses Vector128.Widen instead of 2 calls to WidenLower and WidenUpper. This should result in theory in the same code as Widen is calling these too and returning pair. There might be something like additional store in the emitted code. To chase further, try to compare before and after emitted code of the WidenAsciiToUtf16 method.

NET8 Preview1-Preview6 comparison - choose previews branches, NET8 p1 and p6 in our case, and one of wasm RunConfig's
https://msit.powerbi.com/groups/me/apps/54e0e83f-07bc-45bf-87b7-a7677ff3af2a/reports/b7f22b49-2eb8-4608-933a-13305cc8fab6/ReportSection587f36b937cea0cbe025?experience=power-bi

interpreter
obrazek
only few regressions, overall the performance is improved

AOT
obrazek
there are 200+ regressions from dotnet/perf-autofiling-issues#14019

obrazek
still mostly improvements in AOT as well

Blazor size regression
obrazek

@radekdoulik radekdoulik added this to the 8.0.0 milestone Jun 29, 2023
@radekdoulik radekdoulik self-assigned this Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Issues to look at (most important at top):

AOT related issues
dotnet/perf-autofiling-issues#14019 223 regressions, probably AOT and generics
dotnet/perf-autofiling-issues#13755 23 regressions, might show opportunities for SIMD improvements
dotnet/perf-autofiling-issues#19230 3 regressions, utf16 widening code change

NET8 Preview1-Preview6 comparison - choose previews branches, NET8 p1 and p6 in our case, and one of wasm RunConfig's
https://msit.powerbi.com/groups/me/apps/54e0e83f-07bc-45bf-87b7-a7677ff3af2a/reports/b7f22b49-2eb8-4608-933a-13305cc8fab6/ReportSection587f36b937cea0cbe025?experience=power-bi

interpreter
obrazek
only few regressions, overall the performance is improved

AOT
obrazek
there are 200+ regressions from dotnet/perf-autofiling-issues#14019

obrazek
still mostly improvements in AOT as well

Blazor size regression
obrazek

Author: radekdoulik
Assignees: radekdoulik
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@xtqqczze
Copy link
Contributor

dotnet/perf-autofiling-issues#19230 3 regressions, utf16 widening code change. It now uses Vector128.Widen instead of 2 calls to WidenLower and WidenUpper. This should result in theory in the same code as Widen is calling these too and returning pair. There might be something like additional store in the emitted code. To chase further, try to compare before and after emitted code of the WidenAsciiToUtf16 method.

#87737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants