Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] deadlock while disposing JS object from suspended thread #88663

Closed
pavelsavara opened this issue Jul 11, 2023 · 4 comments
Closed

[browser][MT] deadlock while disposing JS object from suspended thread #88663

pavelsavara opened this issue Jul 11, 2023 · 4 comments
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Milestone
9.0.0

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Jul 11, 2023 •
edited
Loading 

[14:15:48] info: smoke: running GCCollect
[14:30:33] fail: Tests timed out. Killing driver service pid 80

Log
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jul 11, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 11, 2023
@pavelsavara pavelsavara self-assigned this Jul 11, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 11, 2023
@ghost
Copy link

ghost commented Jul 11, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

[14:15:48] info: smoke: running GCCollect
[14:30:33] fail: Tests timed out. Killing driver service pid 80

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, os-browser
Milestone: 8.0.0

@ghost
Copy link

ghost commented Jul 11, 2023

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details 
[14:15:48] info: smoke: running GCCollect
[14:30:33] fail: Tests timed out. Killing driver service pid 80

Log

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-GC-mono, needs-area-label, os-browser
Milestone: 8.0.0

@pavelsavara pavelsavara removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 11, 2023
@pavelsavara pavelsavara mentioned this issue Jul 11, 2023
Merged
@pavelsavara pavelsavara changed the title [browser][MT] deadlock on GCCollect [browser][MT] deadlock on GCCollect/finalizer Jul 12, 2023
@lewing lewing modified the milestones: 8.0.0, 9.0.0 Jul 25, 2023
@pavelsavara
Copy link
Member Author

probably because calling back to JS to free the JS object need be dispatched on suspended thread.

@pavelsavara pavelsavara changed the title [browser][MT] deadlock on GCCollect/finalizer [browser][MT] deadlock while disposing JS object from suspended thread Nov 9, 2023
@pavelsavara pavelsavara mentioned this issue Nov 9, 2023
Closed
31 tasks
@pavelsavara
Copy link
Member Author

This should be resolved because, the dispose is dispatched asynchronously to the owning thread now. See

runtime/src/libraries/System.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.References.cs

Lines 109 to 110 in 72604a4

// async
ProxyContext.SynchronizationContext.Post(static (object? s) =>

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@lewing @pavelsavara