Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode #92246

Closed
BruceForstall opened this issue Sep 18, 2023 · 2 comments · Fixed by #92249
Closed

Test failure: System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode #92246

BruceForstall opened this issue Sep 18, 2023 · 2 comments · Fixed by #92249
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
9.0.0

Comments

@BruceForstall
Copy link
Member

Also,

System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes
System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes

Many failures on x64 in various JitStress runs. Does not fail for MinOpts.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=410217&view=ms.vss-test-web.build-test-results-tab&runId=8923252&resultId=134731&paneView=debug

https://dev.azure.com/dnceng-public/public/_build/results?buildId=410219&view=ms.vss-test-web.build-test-results-tab

e.g.,

net9.0-windows-Release-x64-CoreCLR_checked-no_tiered_compilation-Windows.10.Amd64.Open
System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode

    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(decoded: ")", encoded: "\\u0029") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: \u0029
      Actual:   )
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(357,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(decoded: "E", encoded: "E") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: E
      Actual:   \u0045
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(357,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(decoded: ")", encoded: "\\u0029") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: \u0029
      Actual:   )
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(372,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(decoded: "E", encoded: "E") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: E
      Actual:   \u0045
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(372,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(decoded: ")", encoded: "\\u0029") [FAIL]
      Assert.Equal() Failure
                 � (pos 1)
      Expected: "\u0029"
      Actual:   ")"
                 � (pos 1)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(364,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_AddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(decoded: "E", encoded: "E") [FAIL]
      Assert.Equal() Failure
                 � (pos 1)
      Expected: "E"
      Actual:   "\u0045"
                 � (pos 1)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(364,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_AddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Web.HttpUtility.Tests
=== TEST EXECUTION SUMMARY ===
   System.Web.HttpUtility.Tests  Total: 2361, Errors: 0, Failed: 6, Skipped: 0, Time: 3.744s
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 18, 2023
@BruceForstall BruceForstall added this to the 9.0.0 milestone Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Also,

System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes
System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes

Many failures on x64 in various JitStress runs. Does not fail for MinOpts.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=410217&view=ms.vss-test-web.build-test-results-tab&runId=8923252&resultId=134731&paneView=debug

https://dev.azure.com/dnceng-public/public/_build/results?buildId=410219&view=ms.vss-test-web.build-test-results-tab

e.g.,

net9.0-windows-Release-x64-CoreCLR_checked-no_tiered_compilation-Windows.10.Amd64.Open
System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode

    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(decoded: ")", encoded: "\\u0029") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: \u0029
      Actual:   )
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(357,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(decoded: "E", encoded: "E") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: E
      Actual:   \u0045
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(357,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(decoded: ")", encoded: "\\u0029") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: \u0029
      Actual:   )
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(372,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(decoded: "E", encoded: "E") [FAIL]
      Assert.Equal() Failure
                � (pos 0)
      Expected: E
      Actual:   \u0045
                � (pos 0)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(372,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_ExplicitDontAddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(decoded: ")", encoded: "\\u0029") [FAIL]
      Assert.Equal() Failure
                 � (pos 1)
      Expected: "\u0029"
      Actual:   ")"
                 � (pos 1)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(364,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_AddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(decoded: "E", encoded: "E") [FAIL]
      Assert.Equal() Failure
                 � (pos 1)
      Expected: "E"
      Actual:   "\u0045"
                 � (pos 1)
      Stack Trace:
        /_/src/libraries/System.Web.HttpUtility/tests/HttpUtility/HttpUtilityTest.cs(364,0): at System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode_AddQuotes(String decoded, String encoded)
           at InvokeStub_HttpUtilityTest.JavaScriptStringEncode_AddQuotes(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Web.HttpUtility.Tests
=== TEST EXECUTION SUMMARY ===
   System.Web.HttpUtility.Tests  Total: 2361, Errors: 0, Failed: 6, Skipped: 0, Time: 3.744s
Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: 9.0.0

@BruceForstall
Copy link
Member Author

@EgorBo This is a regression from #87656

@EgorBo EgorBo mentioned this issue Sep 18, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 18, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 19, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Fix optSwitchConvert EgorBo/runtime-1
2 participants
@EgorBo @BruceForstall