Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ProjectReferences for inbox libraries source projects #93877

Open
ViktorHofer opened this issue Oct 23, 2023 · 1 comment · May be fixed by #106329
Open

Use ProjectReferences for inbox libraries source projects #93877

ViktorHofer opened this issue Oct 23, 2023 · 1 comment · May be fixed by #106329
Labels
area-Infrastructure-libraries dev-innerloop in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@ViktorHofer
Copy link
Member

Currently inbox source projects use <Reference /> items instead of <ProjectReference /> items. That design dates back to .NET Core 2.0 days, when dependencies were represented differently. With the continuous work over the last years bringing us closer to the customer path, we should consider updating these to use P2Ps instead.

Here are just some advantages:

  • Dependencies are incrementally built
  • Inbox projects can be built from a fresh clone without any up-front work (!)
  • Faster root builds as a separate reference source projects build isn't necessary anymore.

Blocked on NuGet/NuGet.Client#5452
@ghost
Copy link

ghost commented Oct 23, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently inbox source projects use <Reference /> items instead of <ProjectReference /> items. That design dates back to .NET Core 2.0 days, when dependencies were represented differently. With the continuous work over the last years bringing us closer to the customer path, we should consider updating these to use P2Ps instead.

Here are just some advantages:

  • Dependencies are incrementally built
  • Inbox projects can be built from a fresh clone without any up-front work (!)
  • Faster root builds as a separate reference source projects build isn't necessary anymore.

Blocked on NuGet/NuGet.Client#5452

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 23, 2023
@ViktorHofer ViktorHofer mentioned this issue Oct 23, 2023
Open
@ViktorHofer ViktorHofer added this to the 9.0.0 milestone Oct 25, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 25, 2023
@ViktorHofer ViktorHofer modified the milestones: 9.0.0, 10.0.0 Jul 22, 2024
@ViktorHofer ViktorHofer linked a pull request Aug 17, 2024 that will close this issue
Open
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Infrastructure-libraries dev-innerloop in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Use ProjectReferences in inbox src projects ViktorHofer/runtime
1 participant
@ViktorHofer