Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Lazy loading should be extension agnostic #94132

Closed
maraf opened this issue Oct 28, 2023 · 1 comment · Fixed by #104793
Closed

[browser] Lazy loading should be extension agnostic #94132

maraf opened this issue Oct 28, 2023 · 1 comment · Fixed by #104793
Assignees
@maraf
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Milestone
9.0.0

Comments

@maraf
Copy link
Member

maraf commented Oct 28, 2023 •
edited
Loading

  • Both parts of lazy loading definition requires to use assembly file name (including extension)
  • With webcill an extension for assembly changes from .dll to .wasm
  • Current behavior requires to change lazy loading definition when switching between webcil and non-webcil
  • Ideally lazy loading definition should be without file extension
  • Making both extensions work is a blocker, because JS part of the runtime doesn't currently know if webcil was used or not. We probably could check for file with user passed extension in assets and if not found, check for .wasm
@maraf maraf added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Oct 28, 2023
@maraf maraf added this to the 9.0.0 milestone Oct 28, 2023
@maraf maraf self-assigned this Oct 28, 2023
@ghost
Copy link

ghost commented Oct 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Both parts of lazy loading definition requires to use assembly file name (including extension)
  • With webcill an extension for assembly changes from .dll to .wasm
  • Current behavior requires to change lazy loading definition when switching between webcil and non-webcil
  • Ideally lazy loading definition should be without file extension
  • Making both extensions work is block, because JS part of the runtime doesn't currently know if webcil was used or not. We probably could check for file with user passed extension in assets and if not found, check for .wasm
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@maraf maraf mentioned this issue Mar 28, 2024
Closed
@maraf maraf mentioned this issue Jul 12, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jul 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[browser] Extension agnostic lazy assembly loading maraf/runtime
1 participant
@maraf