Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host tests should move out of the build and use the libraries test infrastructure #94271

Closed
ericstj opened this issue Nov 1, 2023 · 6 comments

Comments

@ericstj
Copy link
Member

ericstj commented Nov 1, 2023

Today host tests run on the build machine inside the build itself. This causes problems - test failures are build failures, they only run on the configurations we happen to build on, etc.

We need to move those tests out of the build. Since they are written as plain old xunit tests they should be able leverage the libraries test infrastructure.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 1, 2023
@ghost
Copy link

ghost commented Nov 1, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Today host tests run on the build machine inside the build itself. This causes problems - test failures are build failures, they only run on the configurations we happen to build on, etc.

We need to move those tests out of the build. Since they are written as plain old xunit tests they should be able leverage the libraries test infrastructure.

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented Nov 1, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Today host tests run on the build machine inside the build itself. This causes problems - test failures are build failures, they only run on the configurations we happen to build on, etc.

We need to move those tests out of the build. Since they are written as plain old xunit tests they should be able leverage the libraries test infrastructure.

Author: ericstj
Assignees: -
Labels:

area-Host, untriaged

Milestone: -

@vitek-karas
Copy link
Member

@elinor-fung has been working towards that for a while - we need to cleanup how the tests get their "Assets" first.

@elinor-fung
Copy link
Member

This is the list I wrote up awhile back for what I think needed to happen:

@ViktorHofer
Copy link
Member

should be able leverage the libraries test infrastructure.

I would go as far as saying "they should leverage the Arcade common test infrastructure". The libraries test infrastructure is more complex and Arcade should already offer everything needed. AFAIK the host tests already use the VSTest runner and submitting to helix is fairly trivial with the Helix Sdk.

@agocke agocke added this to AppModel Nov 28, 2023
@agocke
Copy link
Member

agocke commented Jan 30, 2024

I'm going to close this as a dup of #77800, as I think that covers everything we need

@agocke agocke closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

5 participants