Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][wasi] Set the minimal set of FeatureFlags by default #94805

Closed
Tracked by #94803
lewing opened this issue Nov 15, 2023 · 2 comments
Closed
Tracked by #94803

[mono][wasi] Set the minimal set of FeatureFlags by default #94805

lewing opened this issue Nov 15, 2023 · 2 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Milestone

Comments

@lewing
Copy link
Member

lewing commented Nov 15, 2023

We should review the all the runtime feature flags and document their impact on the wasi build and select an appriate default setting for each.

for example:

    <TrimMode>full</TrimMode>
    <WasmSingleFileBundle>true</WasmSingleFileBundle>
    <InvariantGlobalization>true</InvariantGlobalization>
    <InvariantTimezone>true</InvariantTimezone>
    <WasmBuildNative>true</WasmBuildNative>
    <WasmNativeStrip>false</WasmNativeStrip>
    <UseSystemResourceKeys>true</UseSystemResourceKeys>
    <PredefinedCulturesOnly>true</PredefinedCulturesOnly> <!-- some -->
    <MetricsSupport>false</MetricsSupport> <!-- nothing -->
    <DisableDependencyInjectionDynamicEngine>true</DisableDependencyInjectionDynamicEngine> <!-- nothing -->
    <JsonSerializerIsReflectionEnabledByDefault>false</JsonSerializerIsReflectionEnabledByDefault>
    <DebuggerSupport>false</DebuggerSupport>
    <EnableUnsafeUTF7Encoding>false</EnableUnsafeUTF7Encoding>
    <EventSourceSupport>false</EventSourceSupport>
    <EnableUnsafeBinaryFormatterSerialization>false</EnableUnsafeBinaryFormatterSerialization>
    <StartupHookSupport>false</StartupHookSupport>
    <AutoreleasePoolSupport>false</AutoreleasePoolSupport>
    <CustomResourceTypesSupport>false</CustomResourceTypesSupport>
    <MetadataUpdaterSupport>false</MetadataUpdaterSupport>
    <NullabilityInfoContextSupport>false</NullabilityInfoContextSupport>
    <DynamicCodeSupport>false</DynamicCodeSupport>
    <_AggressiveAttributeTrimming>true</_AggressiveAttributeTrimming>
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 15, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 15, 2023
@lewing lewing added this to the 9.0.0 milestone Nov 15, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 15, 2023
@lewing lewing added the arch-wasm WebAssembly architecture label Nov 15, 2023
@ghost
Copy link

ghost commented Nov 15, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

We should review the all the runtime feature flags and document their impact on the wasi build and select an appriate default setting for each.

Author: lewing
Assignees: -
Labels:

arch-wasm, needs-area-label

Milestone: 9.0.0

@lewing lewing added os-wasi Related to WASI variant of arch-wasm area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 15, 2023
@lewing
Copy link
Member Author

lewing commented Dec 12, 2023

#95486 made most of the feature flags shared between browser and wasi but we should still review the complete set

@lewing lewing self-assigned this Apr 3, 2024
@lewing lewing closed this as completed Jul 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

1 participant