Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] HybridGlobalization on Node, Windows throws with "non-standard" format of era #95623

Closed
ilonatommy opened this issue Dec 5, 2023 · 1 comment · Fixed by #104026
Closed

[browser] HybridGlobalization on Node, Windows throws with "non-standard" format of era #95623

ilonatommy opened this issue Dec 5, 2023 · 1 comment · Fixed by #104026
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-System.Globalization in-pr There is an active PR which will close this issue when it is merged
Milestone
Future

Comments

@ilonatommy
Copy link
Member

System.Runtime test fails after sending "non-standard" format of era to JS for "th" on Windows CI, NodeJS scenario. Cannot reproduce locally, probably depends on NodeJS version. Check which version produces the exception.

[19:07:04] fail: [FAIL] System.Tests.DateTimeTests.TryFormat_MatchesToString(format: "d")
[19:07:04] info: System.Exception : Error: Internal error, era for locale th was in non-standard format.
[19:07:04] info:     at c (file:///C:/helix/work/workitem/e/_framework/dotnet.runtime.js:3:196079)
[19:07:04] info:     at file:///C:/helix/work/workitem/e/_framework/dotnet.runtime.js:3:195883
[19:07:04] info:     at Ql (file:///C:/helix/work/workitem/e/_framework/dotnet.runtime.js:3:196364)
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[317]:0x1f331
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[248]:0x1ca08
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[239]:0xf49b
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[276]:0x1d67c
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[3203]:0xe90f7
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[2523]:0xbedca
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[2522]:0xbed5a
[19:07:04] info:    at System.Globalization.CalendarData.JSLoadCalendarDataFromBrowser(String localeName, CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CalendarData.LoadCalendarDataFromSystemCore(String localeName, CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CalendarData..ctor(String localeName, CalendarId calendarId, Boolean bUseUserOverrides)
[19:07:04] info:    at System.Globalization.CultureData.GetCalendar(CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CultureData.ShortDates(CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CultureData.DateSeparator(CalendarId calendarId)
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo.InitializeOverridableProperties(CultureData cultureData, CalendarId calendarId)
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo..ctor(CultureData cultureData, Calendar cal)
[19:07:04] info:    at System.Globalization.CultureInfo.get_DateTimeFormat()
[19:07:04] info:    at System.Globalization.CultureInfo.GetFormat(Type formatType)
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo.get_CurrentInfo()
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo.GetInstance(IFormatProvider provider)
[19:07:04] info:    at System.DateTimeFormat.Format(DateTime dateTime, String format, IFormatProvider provider, TimeSpan offset)
[19:07:04] info:    at System.DateTimeFormat.Format(DateTime dateTime, String format, IFormatProvider provider)
[19:07:04] info:    at System.DateTime.ToString(String format)
[19:07:04] info:    at System.Tests.DateTimeTests.TryFormat_MatchesToString(String format)
[19:07:04] info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[19:07:04] info:    at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
@ghost
Copy link

ghost commented Dec 5, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Runtime test fails after sending "non-standard" format of era to JS for "th" on Windows CI, NodeJS scenario. Cannot reproduce locally, probably depends on NodeJS version. Check which version produces the exception.

[19:07:04] fail: [FAIL] System.Tests.DateTimeTests.TryFormat_MatchesToString(format: "d")
[19:07:04] info: System.Exception : Error: Internal error, era for locale th was in non-standard format.
[19:07:04] info:     at c (file:///C:/helix/work/workitem/e/_framework/dotnet.runtime.js:3:196079)
[19:07:04] info:     at file:///C:/helix/work/workitem/e/_framework/dotnet.runtime.js:3:195883
[19:07:04] info:     at Ql (file:///C:/helix/work/workitem/e/_framework/dotnet.runtime.js:3:196364)
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[317]:0x1f331
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[248]:0x1ca08
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[239]:0xf49b
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[276]:0x1d67c
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[3203]:0xe90f7
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[2523]:0xbedca
[19:07:04] info:     at wasm://wasm/00b23dde:wasm-function[2522]:0xbed5a
[19:07:04] info:    at System.Globalization.CalendarData.JSLoadCalendarDataFromBrowser(String localeName, CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CalendarData.LoadCalendarDataFromSystemCore(String localeName, CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CalendarData..ctor(String localeName, CalendarId calendarId, Boolean bUseUserOverrides)
[19:07:04] info:    at System.Globalization.CultureData.GetCalendar(CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CultureData.ShortDates(CalendarId calendarId)
[19:07:04] info:    at System.Globalization.CultureData.DateSeparator(CalendarId calendarId)
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo.InitializeOverridableProperties(CultureData cultureData, CalendarId calendarId)
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo..ctor(CultureData cultureData, Calendar cal)
[19:07:04] info:    at System.Globalization.CultureInfo.get_DateTimeFormat()
[19:07:04] info:    at System.Globalization.CultureInfo.GetFormat(Type formatType)
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo.get_CurrentInfo()
[19:07:04] info:    at System.Globalization.DateTimeFormatInfo.GetInstance(IFormatProvider provider)
[19:07:04] info:    at System.DateTimeFormat.Format(DateTime dateTime, String format, IFormatProvider provider, TimeSpan offset)
[19:07:04] info:    at System.DateTimeFormat.Format(DateTime dateTime, String format, IFormatProvider provider)
[19:07:04] info:    at System.DateTime.ToString(String format)
[19:07:04] info:    at System.Tests.DateTimeTests.TryFormat_MatchesToString(String format)
[19:07:04] info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[19:07:04] info:    at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-System.Globalization
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 5, 2023
@ilonatommy ilonatommy mentioned this issue Dec 5, 2023
Merged
@lewing lewing added this to the Future milestone May 2, 2024
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 2, 2024
@ilonatommy ilonatommy mentioned this issue May 23, 2024
Closed
23 tasks
@ilonatommy ilonatommy mentioned this issue Jun 26, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jun 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Enable TryFormat_MatchesToString for HybridGlobalization ilonatommy/runtime
2 participants
@lewing @ilonatommy