Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the HWIntrinsic nodes to allow dead code optimization. #9626

Closed
tannergooding opened this issue Jan 30, 2018 · 3 comments · Fixed by #84110
Closed

Update the HWIntrinsic nodes to allow dead code optimization. #9626

tannergooding opened this issue Jan 30, 2018 · 3 comments · Fixed by #84110
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization tenet-performance Performance related issue
Milestone
Future

Comments

@tannergooding
Copy link
Member

tannergooding commented Jan 30, 2018 •
edited by BruceForstall
Loading

dotnet/coreclr#16066 updated the hardware intrinsic nodes to never be optimized away, under the general assumption that users will be hand optimizing their code.

However, in some cases (such as when inlining, or when constant parameters are passed), it may still be beneficial to optimize away any dead or unreached code.

We should update the HWIntrinsic nodes to properly set and track the SideEffecting flag.

category:cq
theme:hardware-intrinsics
skill-level:intermediate
cost:small
@tannergooding
Copy link
Member Author

FYI. @CarolEidt, @fiigii

@CarolEidt
Copy link
Contributor

@tannergooding - thanks for opening this issue.

@tannergooding
Copy link
Member Author

Moved to the HWIntrinsics project.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@tannergooding tannergooding mentioned this issue Mar 16, 2023
Closed
@tannergooding tannergooding mentioned this issue Mar 30, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 30, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization tenet-performance Performance related issue
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Allow removal of HWIntrinsic nodes that do not have side effects tannergooding/runtime
3 participants
@CarolEidt @msftgits @tannergooding