You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Define APPLE_HYBRID_GLOBALIZATION symbol for the 3 OSes and use it throughout the implementation instead of defined(TARGET_MACCATALYST) || defined(TARGET_IOS) || defined(TARGET_TVOS) conditions in all files under https://github.com/dotnet/runtime/tree/main/src/native/libs/System.Globalization.Native
Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.
Issue Details
Define APPLE_HYBRID_GLOBALIZATION symbol for the 3 OSes and use it throughout the implementation instead of defined(TARGET_MACCATALYST) || defined(TARGET_IOS) || defined(TARGET_TVOS) conditions in all files under https://github.com/dotnet/runtime/tree/main/src/native/libs/System.Globalization.Native
This should be IsHybridGlobalizationOnApplePlatform. It returns true on more OSes, not just iOS. The name does not need to encode the fact that the hybrid globalization is not available in macOS build currently.
mkhamoyan
changed the title
[iOS][non-icu] HybridGlobalization rafactor condition checks
[iOS][non-icu] HybridGlobalization rafactor condition checks / clean up the code
Jan 10, 2024
https://github.com/dotnet/runtime/tree/main/src/native/libs/System.Globalization.Native
HybridGlobalization
is supported only on iOS/tvOS/macCatalyst not OSX. RenameIsHybridGlobalizationOnOSX
/IsNotHybridGlobalizationOnOSX
toIsHybridGlobalizationOnApplePlatform
/IsNotHybridGlobalizationOnApplePlatform
https://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs#L384.IsIcuGlobalizationAndNotHybrid
propertyCheck if possible to include"pal_utilities.h"
inpal_placeholders.h
instead of defining asserts, look discussion [HybridGlobalization] Include all globalization symbols #96684 (comment)we shouldn't mix our configs with pal_config.h.in, so we will keep the way it was implemented.
Contributes to #80689
The text was updated successfully, but these errors were encountered: