Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression on ASP.NET #97406

Closed
sebastienros opened this issue Jan 23, 2024 · 3 comments
Closed

Performance regression on ASP.NET #97406

sebastienros opened this issue Jan 23, 2024 · 3 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue

Comments

@sebastienros
Copy link
Member

sebastienros commented Jan 23, 2024

image

Could only isolate on this commit range since there were no successful builds for 3 days. Seems to impact all scenarios indifferently.

dbb335c...a18d8cd

It doesn't impact NativeAOT (JIT?), and is visible on Windows and Linux.

image

Could be related to #97399 (comment) . The date doesn't match but there weren't any builds since 1/17 until 1/19 so this could be the same reason.

Crank commands:

Before

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/plaintext.benchmarks.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario mvc --profile gold-win-app --profile gold-load-load --application.framework net9.0 --application.collectDependencies true --application.options.collectCounters true --application.aspNetCoreVersion 9.0.0-alpha.1.24069.2 --application.runtimeVersion 9.0.0-alpha.1.24069.4 --application.sdkVersion 9.0.100-alpha.1.24069.3

After

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/plaintext.benchmarks.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario mvc --profile gold-win-app --profile gold-load-load --application.framework net9.0 --application.collectDependencies true --application.options.collectCounters true --application.aspNetCoreVersion 9.0.0-alpha.1.24068.16 --application.runtimeVersion 9.0.0-alpha.1.24066.33 --application.sdkVersion 9.0.100-alpha.1.24068.28
@sebastienros sebastienros added the tenet-performance Performance related issue label Jan 23, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 23, 2024
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 23, 2024
@jkotas
Copy link
Member

jkotas commented Jan 23, 2024

Dup of #97399 (comment) ?

@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 23, 2024
@ghost
Copy link

ghost commented Jan 23, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

image

Could only isolate on this commit range since there were no successful builds for 3 days. Seems to impact all scenarios indifferently.

dbb335c...a18d8cd

It doesn't impact NativeAOT (JIT?), and is visible on Windows and Linux.

image

Could be related to #97399 (comment) . The date doesn't match but there weren't any builds since 1/17 until 1/19 so this could be the same reason.

Crank commands:

Before

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/plaintext.benchmarks.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario mvc --profile gold-win-app --profile gold-load-load --application.framework net9.0 --application.collectDependencies true --application.options.collectCounters true --application.aspNetCoreVersion 9.0.0-alpha.1.24069.2 --application.runtimeVersion 9.0.0-alpha.1.24069.4 --application.sdkVersion 9.0.100-alpha.1.24069.3

After

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/plaintext.benchmarks.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario mvc --profile gold-win-app --profile gold-load-load --application.framework net9.0 --application.collectDependencies true --application.options.collectCounters true --application.aspNetCoreVersion 9.0.0-alpha.1.24068.16 --application.runtimeVersion 9.0.0-alpha.1.24066.33 --application.sdkVersion 9.0.100-alpha.1.24068.28
Author: sebastienros
Assignees: -
Labels:

tenet-performance, area-CodeGen-coreclr, untriaged, needs-area-label

Milestone: -

@sebastienros
Copy link
Member Author

Fixed and verified in benchmarks.

@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

2 participants