Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 2 Regressions on 2/20/2024 7:35:45 PM #99003

Closed
performanceautofiler bot opened this issue Feb 27, 2024 · 5 comments
Closed

[Perf] Linux/x64: 2 Regressions on 2/20/2024 7:35:45 PM #99003

performanceautofiler bot opened this issue Feb 27, 2024 · 5 comments
Labels
arch-x64 area-System.Memory os-linux Linux OS (any supported distro) PGO runtime-coreclr specific to the CoreCLR runtime
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Feb 27, 2024

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 9dc6ea62a4d195ae4559f4609a56933c61889756
Compare 11bdd1b9fc38e137d7945c66790d05b0cd1966ab
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Memory.Span<Byte>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.92 ns 4.27 ns 2.22 0.06 False
1.43 ns 2.98 ns 2.08 0.05 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Memory.Span&lt;Byte&gt;*'

Payloads

Baseline
Compare

System.Memory.Span<Byte>.EndsWith(Size: 33)

ETL Files

Histogram

JIT Disasms

System.Memory.Span<Byte>.EndsWith(Size: 4)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) PGO runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Feb 27, 2024
@DrewScoggins DrewScoggins removed the untriaged New issue has not been triaged by the area owner label Feb 27, 2024
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Feb 27, 2024
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 27, 2024
@ghost
Copy link

ghost commented Feb 27, 2024

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 9dc6ea62a4d195ae4559f4609a56933c61889756
Compare 11bdd1b9fc38e137d7945c66790d05b0cd1966ab
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Memory.Span<Byte>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.92 ns 4.27 ns 2.22 0.06 False
1.43 ns 2.98 ns 2.08 0.05 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Memory.Span&lt;Byte&gt;*'

Payloads

Baseline
Compare

System.Memory.Span<Byte>.EndsWith(Size: 33)

ETL Files

Histogram

JIT Disasms

System.Memory.Span<Byte>.EndsWith(Size: 4)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.Memory, os-linux, arch-x64, untriaged, runtime-coreclr, PGO

Milestone: -

@DrewScoggins
Copy link
Member

Related to #98593

@tannergooding tannergooding added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed untriaged New issue has not been triaged by the area owner labels Jun 24, 2024
@stephentoub
Copy link
Member

cc: @EgorBo

@stephentoub stephentoub added this to the 9.0.0 milestone Jul 22, 2024
@jeffhandley jeffhandley removed the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Aug 6, 2024
@tannergooding
Copy link
Member

This is at worst a 1.6ns regression and has normalized much closer to 1ns.

The improvements were much more meaningful, so closing this as by design.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-System.Memory os-linux Linux OS (any supported distro) PGO runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Development

No branches or pull requests

4 participants