Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert in CounterGroup.OnEventSourceCommand after trying to run BDN x86 #99497

Closed
MichalPetryka opened this issue Mar 10, 2024 · 2 comments · Fixed by #105341
Closed

Assert in CounterGroup.OnEventSourceCommand after trying to run BDN x86 #99497

MichalPetryka opened this issue Mar 10, 2024 · 2 comments · Fixed by #105341
Assignees
Labels
area-Tracing-coreclr in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@MichalPetryka
Copy link
Contributor

MichalPetryka commented Mar 10, 2024

I've tried to run BenchmarkDotNet in x86 (which failed unless I used InProcessEmitToolchain) and after that I've noticed that checked CoreLib is now hitting an assert here:

Debug.Assert(e.Command == EventCommand.Enable || e.Command == EventCommand.Disable);

Seems like BDN somehow corrupt my current PC boot, still, this probably shouldn't assert in .NET when BDN isn't even running anymore.

Stacktrace:

Process terminated. Assertion failed.
   at System.Diagnostics.Tracing.CounterGroup.OnEventSourceCommand(Object sender, EventCommandEventArgs e)
   at System.Diagnostics.Tracing.EventSource.add_EventCommandExecuted(EventHandler`1 value)
   at System.Diagnostics.Tracing.CounterGroup.GetCounterGroup(EventSource eventSource)
   at System.Diagnostics.Tracing.DiagnosticCounter.Publish()
   at System.Diagnostics.Tracing.RuntimeEventSource.OnEventCommand(EventCommandEventArgs command)
   at System.Diagnostics.Tracing.EventSource.DoCommand(EventCommandEventArgs commandArgs)
   at System.Diagnostics.Tracing.EventSource.Initialize(Guid eventSourceGuid, String eventSourceName, String[] traits)
   at System.Diagnostics.Tracing.RuntimeEventSource..ctor()
   at System.Diagnostics.Tracing.RuntimeEventSource.Initialize()
   at System.StartupHookProvider.ManagedStartup(Char* pDiagnosticStartupHooks)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 10, 2024
@filipnavara filipnavara added area-Tracing-coreclr tracking This issue is tracking the completion of other related issues. and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners tracking This issue is tracking the completion of other related issues. labels Mar 10, 2024
@mdh1418
Copy link
Member

mdh1418 commented Mar 11, 2024

Hi Michal, this seems related to #94964 and #96324, both of which seemed to have resolved after the issue authors had restarted their machines. Are you able to reproduce the assert failure reliably in a sample project that you'd be comfortable sharing?

Could you also share the dotnet version you're using along with your machine's specifications?

@MichalPetryka
Copy link
Contributor Author

Are you able to reproduce the assert failure reliably in a sample project that you'd be comfortable sharing?

It was enough to start a Hello world with checked CoreRun built from main, the bigger issue is that I don't know how I made BDN cause such issue.

Could you also share the dotnet version you're using along with your machine's specifications?

I was using a build of the main branch that was a few days old on Windows 10 with Ryzen 9 7900X and 64GB of RAM.

@tommcdon tommcdon added this to the 9.0.0 milestone Mar 12, 2024
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Mar 12, 2024
@mdh1418 mdh1418 self-assigned this Jul 22, 2024
@tommcdon tommcdon added the in-pr There is an active PR which will close this issue when it is merged label Jul 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tracing-coreclr in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants