Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config generator emits lambdas for error path that force allocation on success path #100257

Merged
merged 5 commits into from
May 13, 2024
Merged

Config generator emits lambdas for error path that force allocation on success path #100257

merged 5 commits into from
May 13, 2024

Conversation

pedrobsaila
Copy link
Contributor

Fixes #90971

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 25, 2024
@ericstj ericstj requested review from eiriktsarpalis and tarekgh May 13, 2024 18:28
@tarekgh tarekgh added the source-generator Indicates an issue with a source generator feature label May 13, 2024
@tarekgh tarekgh added this to the 9.0.0 milestone May 13, 2024
@tarekgh
Copy link
Member

tarekgh commented May 13, 2024 

            public const string getPath = nameof(getPath);

This can be removed now?

Refers to: src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Emitter/Helpers.cs:74 in 86d086d. [](commit_id = 86d086d, deletion_comment = False)

@tarekgh
Copy link
Member

tarekgh commented May 13, 2024 •
edited
Loading

@pedrobsaila thanks for submitting the PR. Could you please address the comment #100257 (comment)?

@tarekgh tarekgh merged commit a37af85 into dotnet:main May 13, 2024
83 checks passed
@pedrobsaila pedrobsaila deleted the 90971 branch May 13, 2024 22:25
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@pedrobsaila @eiriktsarpalis
@tarekgh @Ruihan-Yin
Config generator emits lambdas for error path that force allocation o…
f1600ff 
…n success path (dotnet#100257)

* first draft

* fix failing tests

* delete no more used Identifier.getPath

---------

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Config generator emits lambdas for error path that force allocation on success path
3 participants
@pedrobsaila @tarekgh @eiriktsarpalis