From a1b71a28173f317e441841dbe09b4f6ff4c4d783 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Sat, 15 Jun 2024 00:42:00 +0200 Subject: [PATCH 1/4] Revert "Do not set UseNativeAotForComponents for arm32 MUSL (#103469)" This reverts commit f1f075012af193948fa2d33e24adfbc8d92b8782. --- eng/Subsets.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Subsets.props b/eng/Subsets.props index af82931673ccd5..71b409a84f6e2f 100644 --- a/eng/Subsets.props +++ b/eng/Subsets.props @@ -122,7 +122,7 @@ <_NativeAotSupportedOS Condition="'$(TargetOS)' == 'windows' or '$(TargetOS)' == 'linux' or '$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or '$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'freebsd'">true <_NativeAotSupportedArch Condition="'$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'arm' or ('$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86')">true true - true + true true From 4f26c125a31705fb361a6d768b3a0430589063b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Sat, 15 Jun 2024 00:42:08 +0200 Subject: [PATCH 2/4] Revert "Set UseNativeAotForComponents to false on bionic (#103454)" This reverts commit d901213ed6076c0989a2de2626b99c9711442543. --- eng/Subsets.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Subsets.props b/eng/Subsets.props index 71b409a84f6e2f..20c449b02cd4ac 100644 --- a/eng/Subsets.props +++ b/eng/Subsets.props @@ -122,7 +122,7 @@ <_NativeAotSupportedOS Condition="'$(TargetOS)' == 'windows' or '$(TargetOS)' == 'linux' or '$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or '$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'freebsd'">true <_NativeAotSupportedArch Condition="'$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'arm' or ('$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86')">true true - true + true true From 5fb68c9d49469e38ba2a4b7f25a7486e7582e6b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Sat, 15 Jun 2024 00:42:50 +0200 Subject: [PATCH 3/4] Revert "Try fixing x86 Windows legs (#103411)" This reverts commit 6927fea7b4bca1dc2cea7a0afba0373c1303cedc. --- eng/Subsets.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/Subsets.props b/eng/Subsets.props index 20c449b02cd4ac..4b6ed2c550ee83 100644 --- a/eng/Subsets.props +++ b/eng/Subsets.props @@ -122,7 +122,7 @@ <_NativeAotSupportedOS Condition="'$(TargetOS)' == 'windows' or '$(TargetOS)' == 'linux' or '$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or '$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'freebsd'">true <_NativeAotSupportedArch Condition="'$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'arm' or ('$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86')">true true - true + true true From 91ac851fd0dd95873d2566b991e168ec43574bef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Sat, 15 Jun 2024 00:43:14 +0200 Subject: [PATCH 4/4] Revert "Consolidate <_NativeAotSupportedOS Condition="'$(TargetOS)' == 'windows' or '$(TargetOS)' == 'linux' or '$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or '$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'freebsd'">true <_NativeAotSupportedArch Condition="'$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64' or '$(TargetArchitecture)' == 'arm' or ('$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86')">true - true - true + true true @@ -287,10 +286,7 @@ AdditionalProperties="%(AdditionalProperties); ClrCrossComponentsSubset=true; HostArchitecture=$(BuildArchitecture); - TargetArchitecture=$(TargetArchitecture); HostCrossOS=$(HostOS); - HostOS=$(HostOS); - TargetOS=$(TargetOS); PgoInstrument=false; NoPgoOptimize=true; CrossBuild=false; diff --git a/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj b/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj index ffab9cbb1289b1..823dab33c645c4 100644 --- a/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj +++ b/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj @@ -10,15 +10,20 @@ $(RuntimeBinDir)ilc-published/ - true - $(ROOTFS_DIR) - true - true - true + false + false + false + + false + true + $(ROOTFS_DIR) + true + true + true true - + @@ -48,7 +53,7 @@ clang @@ -70,7 +75,7 @@ <_XcodeVersion>$([System.Text.RegularExpressions.Regex]::Match($(_XcodeVersionString), '[1-9]\d*')) - + @@ -81,7 +86,7 @@ - + diff --git a/src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj b/src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj index 14d0fa48fa41d7..657ac23590a039 100644 --- a/src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj +++ b/src/coreclr/tools/aot/crossgen2/crossgen2_publish.csproj @@ -7,6 +7,11 @@ + false + false + false + + false true $(PackageRID) true @@ -16,7 +21,7 @@ - + true true @@ -36,7 +41,7 @@ - + $(CoreCLRILCompilerDir) $(CoreCLRCrossILCompilerDir) $(ROOTFS_DIR) @@ -50,12 +55,12 @@ --flat - + + Condition="'$(NativeAotSupported)' == 'true'" /> @@ -83,7 +88,7 @@ clang diff --git a/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj b/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj index c9d40b79d38db5..8d492718edd92a 100644 --- a/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj +++ b/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj @@ -15,6 +15,8 @@ true false + + false diff --git a/src/native/managed/compile-native.proj b/src/native/managed/compile-native.proj index ef7b427944efca..bcda8c5d6b57b5 100644 --- a/src/native/managed/compile-native.proj +++ b/src/native/managed/compile-native.proj @@ -13,11 +13,26 @@ + + + + false + + false + + false + + false + false + true + false + + $(ROOTFS_DIR) lld - --gcc-toolchain=$(ROOTFS_DIR)/usr + --gcc-toolchain=$(ROOTFS_DIR)/usr @@ -36,6 +51,6 @@ ReferenceOutputAssembly="false" AdditionalProperties="%(AdditionalProperties);$(SplitSubprojectProps)" Targets="LinkNative" - Condition="'$(UseNativeAotForComponents)' == 'true'"/> + Condition="$(SupportsNativeAotComponents)"/>