[wasi] wasi:http + WasiHttpHandler #103752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
force-pushed
the
wasip2-2
branch
2 times, most recently
from
b95ccf8
to
1f8d2a4
Compare
This was referenced Jun 20, 2024
Open
ilonatommy
reviewed
Jun 28, 2024
This was referenced Jun 28, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Open
pavelsavara
commented
Jul 2, 2024
src/libraries/System.Private.CoreLib/src/System/Threading/Thread.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Threading/WASI/WasiEventLoop.cs
Outdated
Show resolved
Hide resolved
src/mono/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.WASI.xml
Outdated
Show resolved
Hide resolved
pavelsavara
changed the title
jkotas
reviewed
Jul 2, 2024
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
lewing
reviewed
Jul 29, 2024
src/mono/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.WASI.xml
Outdated
Show resolved
Hide resolved
This was referenced Jul 30, 2024
This was referenced Jul 31, 2024
3 tasks
This was referenced Aug 1, 2024
ilonatommy
reviewed
Aug 1, 2024
akoeplinger
approved these changes
Aug 1, 2024
| @@ -455,6 +455,22 @@ | |||
| Link="Common\System\Net\Http\HttpHandlerDefaults.cs" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'wasi'"> | |||
| <Reference Include="System.Threading.Thread" /> | |||
There was a problem hiding this comment.
nit: please move this to the ItemGroup below which has all the Reference items
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stealing code and ideas from dotnet/runtimelab#2614
System.Threading.WasiEventLoopmade accessible viaThreadclassWasiHttpHandlerand generatedWasiHttpWorld.wit.importscredits to @dicej & @SingleAccretion
Contributes to #96419
Contributes to #98957
Parts are moved to