Revert "Migrate to zlib-ng, part 2: consume it in runtime" #104414

agocke · 2024-07-04T03:16:08Z

Looks like that change broke the official build.

This reverts commit f5c9a5e.

ilonatommy · 2024-07-04T09:45:07Z

Current error when building locally:

 /usr/bin/ld: /home/user/Projects/dotnet-runtime-wasm/artifacts/obj/mono/browser.wasm.Release/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFAcceleratorTable.cpp.o): in function `llvm::DWARFDebugNames::ValueIterator::findEntryOffsetInCurrentIndex()':
  DWARFAcceleratorTable.cpp:(.text+0x51fa): undefined reference to `llvm::caseFoldingDjbHash(llvm::StringRef, unsigned int)'
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

Trying to fix it we added OR LLVM_PREFIX to https://github.com/dotnet/runtime/blob/main/eng/native/configureplatform.cmake#L504-L508. This results in an error:

  /usr/bin/ld: cannot find -lzlib: No such file or directory
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

in mono/mini/mono-aot-cross step.

pavelsavara

We have some issues building wasm/browser locally. We are not sure why CI passed yet.

The zlib-ng change is also making my attempt to upgrade to WASIp2 libc complicated.
I think we should merge the revert and try again without WASM targets, put them in similar bucket as other Mobile targets.

I wonder, was there reason to specifically enable it for wasm ?

cc @carlossanlop

ilonatommy · 2024-07-04T13:47:39Z

/ba-g failures not connected

carlossanlop · 2024-07-04T17:32:05Z

@ilonatommy what build command did you run locally which reproed the problem?

carlossanlop · 2024-07-04T17:33:42Z

I'm surprised failures were encountered since the CI passed in my PR in all the runs: runtime, runtime-extra-platforms, runtime-nativeaot-outerloop, runtime-community.

@ilonatommy @pavelsavara is there a wasm specific azp run I should also execute?

pavelsavara · 2024-07-04T18:16:47Z

@ilonatommy @kg reported

 /usr/bin/ld: /home/kate/Projects/dotnet-runtime-wasm/artifacts/obj/mono/browser.wasm.Release/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFAcceleratorTable.cpp.o): in function `llvm::DWARFDebugNames::ValueIterator::findEntryOffsetInCurrentIndex()':
  DWARFAcceleratorTable.cpp:(.text+0x51fa): undefined reference to `llvm::caseFoldingDjbHash(llvm::StringRef, unsigned int)'
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

On their local systems. I don't understand what it means. @akoeplinger hinted that maybe it still tried to link the other zlib too.

My issue with WASI + wasip2 is not merged yet into main, so you could not have see those.
I'm woking on it here #103752

When I merged your zlib-ng changes I got

  -- Check size of void * - failed
  -- sizeof(void *) is  bytes
  CMake Error at C:/Dev/runtime/src/native/external/zlib-ng/CMakeLists.txt:485 (message):
    sizeof(void *) is neither 32 nor 64 bit

When I hacked that I got ton of other problems, for which I don't have log anymore. Sorry.
It was not single issue tho, it was massive.

We are willing to collaborate to figure it out.

The other option is to merge your PR without wasm changes and get there in subsequent PR.
Same as other mobile targets.
That would be my preference.

We saw that the revert is for the official build reason and welcomed that we could get unblocked.

carlossanlop · 2024-07-04T19:50:37Z

Looks like that change broke the official build.
@agocke do you have a link to the official build showing the failure?

carlossanlop · 2024-07-04T19:51:13Z

The other option is to merge your PR without wasm changes and get there in subsequent PR.

Yes, I think this is the best option. I'm working on it.

kg · 2024-07-04T20:02:51Z

@ilonatommy what build command did you run locally which reproed the problem?

For me regular ./build.sh --os browser broke, I think. I can test again later.

…2403)" (dotnet#104414) This reverts commit 5b86dca.

ilonatommy · 2024-07-05T10:39:24Z

@ilonatommy what build command did you run locally which reproed the problem?

Regular runtime build for WASM: ./build.sh mono+libs -c release -os browser

agocke · 2024-07-05T14:34:28Z

See https://dnceng.visualstudio.com/internal/_build/results?buildId=2487705 and the next few builds.

carlossanlop · 2024-07-05T20:17:37Z

See https://dnceng.visualstudio.com/internal/_build/results?buildId=2487705 and the next few builds.

@agocke I don't see any wasm failures.

carlossanlop · 2024-07-05T20:19:18Z

Oh, but tut there's a nativeaot failure related to my change:

D:\a\_work\1\s\.packages\microsoft.dotnet.sharedframework.sdk\9.0.0-beta.24327.1\targets\sharedfx.targets(296,5): error : zlibstatic.lib. Add these file names with extensions to the 'PlatformManifestFileEntry' item group for the runtime pack and corresponding ref pack to include them in the platform manifest. [D:\a\_work\1\s\src\installer\pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Runtime.sfxproj]

I'm surprised that I did not see that one in the CI of my PR. I think I know how to fix that one.

carlossanlop · 2024-07-05T20:40:19Z

Is there an azp run that would execute the same or similar nativeaot command? In my PR I ran nativeaot-outerloop, and the failure did not show up there.

jkotas · 2024-07-05T20:56:00Z

Is there an azp run that would execute the same or similar nativeaot command? I

There is no such command in dotnet/runtime. This is bug in the installed layout. We do not have any tests in dotnet/runtime that run validation against installed layout. e2e tests like that are in sdk and source build repos.

carlossanlop · 2024-07-05T20:57:36Z

Thanks. Fortunately I was able to repro it locally and also fix it locally with this commit: d232aaf

pavelsavara · 2024-07-08T17:46:26Z

The PR which switches to WASI preview 2 is #103752

the build problems of zlib-ng in WASI preview 2 are :

CMake Error at C:/Dev/runtime/src/native/external/zlib-ng/CMakeLists.txt:485 (message):

    sizeof(void *) is neither 32 nor 64 bit

C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/zutil_p.h(29,20): error G53F6472F: call to undeclared function 'memalign'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] [C:\Dev\runtime\src\nativ
e\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate_medium.c(162,13): error G91F14494: passing arguments to 'ALIGNED_' without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype] [C:\Dev\run
time\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate_medium.c(162,17): error G0708A3E5: expected ';' after expression [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/zutil_p.h(29,20): error G53F6472F: call to undeclared function 'memalign'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] [C:\Dev\runtime\src\nativ
e\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.c(460,54): error G8D1AB72F: no member named 'crc_fold' in 'struct internal_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.c(797,40): error G8D1AB72F: no member named 'crc_fold' in 'struct internal_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.c(914,44): error G8D1AB72F: no member named 'crc_fold' in 'struct internal_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.c(985,54): error G8D1AB72F: no member named 'crc_fold' in 'struct internal_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.c(1098,49): error G8D1AB72F: no member named 'crc_fold' in 'struct internal_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.h(107,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,34): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,37): error G0708A3E5: expected ';' at end of declaration list [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(217,25): error GA7A3AA14: field 'ALIGNED_' declared as a function [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G29FB4A59: expected parameter declarator [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/deflate.h(287,12): error G0708A3E5: expected ')' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.c(31,43): error G8D1AB72F: no member named 'crc_fold' in 'struct inflate_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.c(43,38): error G8D1AB72F: no member named 'crc_fold' in 'struct inflate_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.c(639,81): error G8D1AB72F: no member named 'crc_fold' in 'struct inflate_state' [C:\Dev\runtime\src\native\libs\build-native.proj]
C:/Dev/runtime/src/native/external/zlib-ng/inflate.c(1059,89): error G8D1AB72F: no member named 'crc_fold' in 'struct inflate_state' [C:\Dev\runtime\src\native\libs\build-native.proj]

pavelsavara · 2024-07-08T18:33:11Z

The failure in the codespaces is

  [383/385] Linking CXX static library mono/mini/libmonosgen-2.0.a
  [384/385] Linking CXX executable mono/mini/mono-aot-cross
  FAILED: mono/mini/mono-aot-cross 
  : && /usr/bin/clang++-14 -I/workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/include/c++/v1 -L/workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib -stdlib=libc++ -Wl,--build-id=sha1 -fno-strict-aliasing -fwrapv -Wall -Wunused -Wmissing-declarations -Wpointer-arith -Wno-cast-qual -Wwrite-strings -Wno-switch -Wno-switch-enum -Wno-unused-value -Wno-attributes -Wno-format-zero-length -Wno-unused-function -Qunused-arguments -Wno-tautological-compare -Wno-parentheses-equality -Wno-self-assign -Wno-return-stack-address -Wno-constant-logical-operand -Wno-zero-length-array -Wno-asm-operand-widths -Werror=return-type -I/workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/include -isystem /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/include/c++/v1 -std=c++17 -nostdinc++ -nostdlib++ -fno-exceptions -fno-rtti -D__STDC_CONSTANT_MACROS -D__STD_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fexceptions -fno-rtti -g -pie    -Wl,-z,relro -Wl,-z,now mono/mini/CMakeFiles/marshal-ilgen-objects.dir/__/component/marshal-ilgen.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-allocator.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-fwd-list.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-list.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-queue.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-umap.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-vector.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-simdhash.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-simdhash-string-ptr.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-simdhash-u32-ptr.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-simdhash-ptr-ptr.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-simdhash-ght-compatible.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-simdhash-ptrpair-ptr.c.o mono/mini/containers/CMakeFiles/dn-containers.dir/dn-simdhash-utils.c.o mono/mini/CMakeFiles/mono-sgen.dir/main.c.o mono/mini/CMakeFiles/mono-sgen.dir/__/__/public_apis/validate-apis.c.o -o mono/mini/mono-aot-cross  -Wl,-rpath,:::::::  mono/mini/libmonosgen-2.0.a  _deps/fetchzlibng-build/libz.a  -lpthread  -lm  -ldl  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMOrcJIT.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMPasses.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMCoroutines.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMipo.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMInstrumentation.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMVectorize.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMScalarOpts.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMLinker.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMIRReader.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMAsmParser.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMInstCombine.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMFrontendOpenMP.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMAggressiveInstCombine.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMTransformUtils.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMJITLink.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMMCJIT.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMExecutionEngine.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMTarget.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMRuntimeDyld.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMBitWriter.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMAnalysis.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMProfileData.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMObject.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMTextAPI.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMMCParser.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMMC.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoCodeView.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMBitReader.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMCore.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMRemarks.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMBitstreamReader.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMBinaryFormat.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMSupport.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDemangle.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMIRPrinter.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMCodeGen.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMObjCARCOpts.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMMCDisassembler.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMWindowsDriver.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMOption.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMOrcTargetProcess.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMOrcShared.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMSymbolize.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoPDB.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoMSF.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a  /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMTargetParser.a  -L/workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib -lc++ -lc++abi  -lrt  -ldl  -lpthread  -lm  _deps/fetchzlibng-build/libz.a && cd /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini && sh -c "echo Stripping symbols from \$(basename '/workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini/mono-aot-cross') into \$(basename '/workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini/mono-aot-cross.dbg')" && /usr/bin/llvm-objcopy-14 --only-keep-debug /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini/mono-aot-cross /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini/mono-aot-cross.dbg && /usr/bin/llvm-objcopy-14 --strip-debug --strip-unneeded /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini/mono-aot-cross && /usr/bin/llvm-objcopy-14 --add-gnu-debuglink=/workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini/mono-aot-cross.dbg /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/cross/mono/mini/mono-aot-cross
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMObject.a(OffloadBinary.cpp.o): in function `llvm::object::extractOffloadBinaries(llvm::MemoryBufferRef, llvm::SmallVectorImpl<llvm::object::OffloadFile>&)':
  OffloadBinary.cpp:(.text+0xa39): undefined reference to `llvm::getLazyIRModule(std::__1::unique_ptr<llvm::MemoryBuffer, std::__1::default_delete<llvm::MemoryBuffer> >, llvm::SMDiagnostic&, llvm::LLVMContext&, bool)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFContext.cpp.o): in function `llvm::DWARFContext::create(llvm::object::ObjectFile const&, llvm::DWARFContext::ProcessDebugRelocations, llvm::LoadedObjectInfo const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::function<void (llvm::Error)>, std::__1::function<void (llvm::Error)>)':
  DWARFContext.cpp:(.text+0xf8d0): undefined reference to `llvm::object::Decompressor::create(llvm::StringRef, llvm::StringRef, bool, bool)'
  /usr/bin/ld: DWARFContext.cpp:(.text+0xf963): undefined reference to `llvm::object::Decompressor::decompress(llvm::MutableArrayRef<unsigned char>)'
  /usr/bin/ld: DWARFContext.cpp:(.text+0x1019f): undefined reference to `llvm::object::getRelocationResolver(llvm::object::ObjectFile const&)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFDataExtractor.cpp.o): in function `llvm::DWARFDataExtractor::getRelocatedValue(unsigned int, unsigned long*, unsigned long*, llvm::Error*) const':
  DWARFDataExtractor.cpp:(.text+0x2e9): undefined reference to `llvm::object::resolveRelocation(unsigned long (*)(unsigned long, unsigned long, unsigned long, unsigned long, long), llvm::object::RelocationRef const&, unsigned long, unsigned long)'
  /usr/bin/ld: DWARFDataExtractor.cpp:(.text+0x307): undefined reference to `llvm::object::resolveRelocation(unsigned long (*)(unsigned long, unsigned long, unsigned long, unsigned long, long), llvm::object::RelocationRef const&, unsigned long, unsigned long)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `llvm::DWARFVerifier::verifyNameIndexBuckets(llvm::DWARFDebugNames::NameIndex const&, llvm::DataExtractor const&)':
  DWARFVerifier.cpp:(.text+0x8769): undefined reference to `llvm::caseFoldingDjbHash(llvm::StringRef, unsigned int)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text+0x88e9): undefined reference to `llvm::caseFoldingDjbHash(llvm::StringRef, unsigned int)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::iterator::insert(unsigned long, unsigned long, unsigned long)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator6insertEmmm[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator6insertEmmm]+0xac): undefined reference to `llvm::IntervalMapImpl::Path::replaceRoot(void*, unsigned int, std::__1::pair<unsigned int, unsigned int>)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::iterator::treeInsert(unsigned long, unsigned long, unsigned long)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10treeInsertEmmm[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10treeInsertEmmm]+0x3c): undefined reference to `llvm::IntervalMapImpl::Path::moveLeft(unsigned int)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10treeInsertEmmm[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10treeInsertEmmm]+0x77): undefined reference to `llvm::IntervalMapImpl::Path::getLeftSibling(unsigned int) const'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10treeInsertEmmm[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10treeInsertEmmm]+0xc8): undefined reference to `llvm::IntervalMapImpl::Path::moveLeft(unsigned int)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::branchRoot(unsigned int)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE10branchRootEj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE10branchRootEj]+0x30): undefined reference to `llvm::IntervalMapImpl::distribute(unsigned int, unsigned int, unsigned int, unsigned int const*, unsigned int*, unsigned int, bool)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::iterator::treeErase(bool)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator9treeEraseEb[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator9treeEraseEb]+0x262): undefined reference to `llvm::IntervalMapImpl::Path::moveRight(unsigned int)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `bool llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::iterator::overflow<llvm::IntervalMapImpl::LeafNode<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> > >(unsigned int)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj]+0x2e): undefined reference to `llvm::IntervalMapImpl::Path::getLeftSibling(unsigned int) const'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj]+0x8a): undefined reference to `llvm::IntervalMapImpl::Path::getRightSibling(unsigned int) const'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj]+0x176): undefined reference to `llvm::IntervalMapImpl::distribute(unsigned int, unsigned int, unsigned int, unsigned int const*, unsigned int*, unsigned int, bool)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj]+0x1a6): undefined reference to `llvm::IntervalMapImpl::Path::moveLeft(unsigned int)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj]+0x2a2): undefined reference to `llvm::IntervalMapImpl::Path::moveRight(unsigned int)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl8LeafNodeImmLj8ES2_EEEEbj]+0x2e7): undefined reference to `llvm::IntervalMapImpl::Path::moveLeft(unsigned int)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::iterator::eraseNode(unsigned int)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator9eraseNodeEj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator9eraseNodeEj]+0x482): undefined reference to `llvm::IntervalMapImpl::Path::moveRight(unsigned int)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::iterator::insertNode(unsigned int, llvm::IntervalMapImpl::NodeRef, unsigned long)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10insertNodeEjNS_15IntervalMapImpl7NodeRefEm[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10insertNodeEjNS_15IntervalMapImpl7NodeRefEm]+0x1e6): undefined reference to `llvm::IntervalMapImpl::Path::replaceRoot(void*, unsigned int, std::__1::pair<unsigned int, unsigned int>)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10insertNodeEjNS_15IntervalMapImpl7NodeRefEm[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator10insertNodeEjNS_15IntervalMapImpl7NodeRefEm]+0x21b): undefined reference to `llvm::IntervalMapImpl::Path::moveLeft(unsigned int)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFVerifier.cpp.o): in function `bool llvm::IntervalMap<unsigned long, unsigned long, 8u, llvm::IntervalMapInfo<unsigned long> >::iterator::overflow<llvm::IntervalMapImpl::BranchNode<unsigned long, unsigned long, 12u, llvm::IntervalMapInfo<unsigned long> > >(unsigned int)':
  DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj]+0x2e): undefined reference to `llvm::IntervalMapImpl::Path::getLeftSibling(unsigned int) const'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj]+0x8a): undefined reference to `llvm::IntervalMapImpl::Path::getRightSibling(unsigned int) const'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj]+0x179): undefined reference to `llvm::IntervalMapImpl::distribute(unsigned int, unsigned int, unsigned int, unsigned int const*, unsigned int*, unsigned int, bool)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj]+0x1a9): undefined reference to `llvm::IntervalMapImpl::Path::moveLeft(unsigned int)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj]+0x292): undefined reference to `llvm::IntervalMapImpl::Path::moveRight(unsigned int)'
  /usr/bin/ld: DWARFVerifier.cpp:(.text._ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj[_ZN4llvm11IntervalMapImmLj8ENS_15IntervalMapInfoImEEE8iterator8overflowINS_15IntervalMapImpl10BranchNodeImmLj12ES2_EEEEbj]+0x2d7): undefined reference to `llvm::IntervalMapImpl::Path::moveLeft(unsigned int)'
  /usr/bin/ld: /workspaces/runtime/artifacts/obj/mono/wasi.wasm.Debug/llvm//x64/lib/libLLVMDebugInfoDWARF.a(DWARFAcceleratorTable.cpp.o): in function `llvm::DWARFDebugNames::ValueIterator::findEntryOffsetInCurrentIndex()':
  DWARFAcceleratorTable.cpp:(.text+0x51fa): undefined reference to `llvm::caseFoldingDjbHash(llvm::StringRef, unsigned int)'
  clang: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

…104454) * Reapply "Migrate to zlib-ng, part 2: consume it in runtime (#102403)" (#104414) * Apply jkotas comment suggestion in configureplatform.cmake * Delete unnecessary comment in zlib-ng.cmake * Fix windows nativeaot failure happening when executing: build.cmd -ci -arch x64 -os windows -s clr.nativeaotlibs+clr.nativeaotruntime+libs+packs -c Release /p:BuildNativeAOTRuntimePack=true /p:SkipLibrariesNativeRuntimePackages=true

Revert "Migrate to zlib-ng, part 2: consume it in runtime (#102403)"

9c3cb28

This reverts commit f5c9a5e.

agocke requested review from lewing, pavelsavara, BrzVlad, lambdageek, steveisok, lateralusX, thaystg, marek-safar and MichalStrehovsky as code owners July 4, 2024 03:16

dotnet-issue-labeler bot added the area-Build-mono label Jul 4, 2024

dotnet-policy-service bot assigned agocke Jul 4, 2024

jkotas approved these changes Jul 4, 2024

View reviewed changes

This was referenced Jul 4, 2024

[wasm][MT] null function or function signature mismatch #101481

Open

System.Buffers.Tests timeout on wasm MT #102040

Open

[browser][MT] test failure: Tests timed out. Killing driver service #103524

Open

pavelsavara approved these changes Jul 4, 2024

View reviewed changes

ilonatommy merged commit 5b86dca into main Jul 4, 2024
156 of 159 checks passed

This was referenced Jul 4, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

The job running on agent NetCore-Public ran longer than the maximum time #104044

Closed

stephentoub deleted the revert-102403-zlib-ng branch July 4, 2024 17:15

carlossanlop mentioned this pull request Jul 4, 2024

Migrate to zlib-ng, part 3: Remove zlib and zlib-intel source code and license mentions #104399

Merged

carlossanlop added a commit to carlossanlop/runtime that referenced this pull request Jul 4, 2024

Reapply "Migrate to zlib-ng, part 2: consume it in runtime (dotnet#10…

c0a6c60

…2403)" (dotnet#104414) This reverts commit 5b86dca.

carlossanlop mentioned this pull request Jul 5, 2024

Migrate to zlib-ng, part 2: consume it in runtime (second attempt) #104454

Merged

github-actions bot locked and limited conversation to collaborators Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Migrate to zlib-ng, part 2: consume it in runtime" #104414

Revert "Migrate to zlib-ng, part 2: consume it in runtime" #104414

agocke commented Jul 4, 2024 •

edited

Loading

ilonatommy commented Jul 4, 2024 •

edited

Loading

pavelsavara left a comment •

edited

Loading

ilonatommy commented Jul 4, 2024

carlossanlop commented Jul 4, 2024

carlossanlop commented Jul 4, 2024

pavelsavara commented Jul 4, 2024 •

edited

Loading

carlossanlop commented Jul 4, 2024

carlossanlop commented Jul 4, 2024

kg commented Jul 4, 2024

ilonatommy commented Jul 5, 2024

agocke commented Jul 5, 2024 •

edited

Loading

carlossanlop commented Jul 5, 2024

carlossanlop commented Jul 5, 2024 •

edited

Loading

carlossanlop commented Jul 5, 2024

jkotas commented Jul 5, 2024

carlossanlop commented Jul 5, 2024

pavelsavara commented Jul 8, 2024 •

edited

Loading

pavelsavara commented Jul 8, 2024

Revert "Migrate to zlib-ng, part 2: consume it in runtime" #104414

Revert "Migrate to zlib-ng, part 2: consume it in runtime" #104414

Conversation

agocke commented Jul 4, 2024 • edited Loading

ilonatommy commented Jul 4, 2024 • edited Loading

pavelsavara left a comment • edited Loading

Choose a reason for hiding this comment

ilonatommy commented Jul 4, 2024

carlossanlop commented Jul 4, 2024

carlossanlop commented Jul 4, 2024

pavelsavara commented Jul 4, 2024 • edited Loading

carlossanlop commented Jul 4, 2024

carlossanlop commented Jul 4, 2024

kg commented Jul 4, 2024

ilonatommy commented Jul 5, 2024

agocke commented Jul 5, 2024 • edited Loading

carlossanlop commented Jul 5, 2024

carlossanlop commented Jul 5, 2024 • edited Loading

carlossanlop commented Jul 5, 2024

jkotas commented Jul 5, 2024

carlossanlop commented Jul 5, 2024

pavelsavara commented Jul 8, 2024 • edited Loading

pavelsavara commented Jul 8, 2024

agocke commented Jul 4, 2024 •

edited

Loading

ilonatommy commented Jul 4, 2024 •

edited

Loading

pavelsavara left a comment •

edited

Loading

pavelsavara commented Jul 4, 2024 •

edited

Loading

agocke commented Jul 5, 2024 •

edited

Loading

carlossanlop commented Jul 5, 2024 •

edited

Loading

pavelsavara commented Jul 8, 2024 •

edited

Loading